Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 1045313003: Converted accessibility_unittests to run on Swarming everywhere. (Closed)

Created:
5 years, 8 months ago by M-A Ruel
Modified:
5 years, 8 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, jam, jochen (gone - plz use gerrit), scottmg
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@3_convert_to_swarming
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Converted accessibility_unittests to run on Swarming everywhere. Ran: ./manage.py --convert accessibility_unittests R=phajdan.jr@chromium.org BUG=98637 Committed: https://crrev.com/e664426489b42727c0d9d51a33eb4546d6e76488 Cr-Commit-Position: refs/heads/master@{#323229}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove from OSX 10.10 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
M testing/buildbot/chromium.chromiumos.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 6 chunks +18 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 chunk +3 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
M-A Ruel
Follow up of https://codereview.chromium.org/1048213003. It makes the switch over trivial, so the next tests will ...
5 years, 8 months ago (2015-03-31 19:12:51 UTC) #1
M-A Ruel
https://codereview.chromium.org/1045313003/diff/1/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/1045313003/diff/1/testing/buildbot/chromium.fyi.json#newcode76 testing/buildbot/chromium.fyi.json:76: "can_use_on_swarming_builders": true There's no Swarming 10.10 OSX bots at ...
5 years, 8 months ago (2015-03-31 19:23:41 UTC) #2
Paweł Hajdan Jr.
LGTM
5 years, 8 months ago (2015-04-01 10:05:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045313003/20001
5 years, 8 months ago (2015-04-01 12:38:02 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-01 13:49:34 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 13:51:03 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e664426489b42727c0d9d51a33eb4546d6e76488
Cr-Commit-Position: refs/heads/master@{#323229}

Powered by Google App Engine
This is Rietveld 408576698