Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1461)

Unified Diff: Source/devtools/front_end/TimelineOverviewPane.js

Issue 104523002: [DevTools] Add power profiler and power overview in timeline panel. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/TimelineOverviewPane.js
diff --git a/Source/devtools/front_end/TimelineOverviewPane.js b/Source/devtools/front_end/TimelineOverviewPane.js
index 307c973982abe4802132ef7361ece5726a68616b..499bb5894a34c5df93ec80e3e4c732681b6c5a0e 100644
--- a/Source/devtools/front_end/TimelineOverviewPane.js
+++ b/Source/devtools/front_end/TimelineOverviewPane.js
@@ -38,6 +38,9 @@ WebInspector.TimelineOverviewPane = function(model)
WebInspector.View.call(this);
this.element.id = "timeline-overview-pane";
+ if (WebInspector.experimentsSettings.powerProfiler.isEnabled() && Capabilities.canProfilePower)
+ this.element.classList.add("power-overview");
pfeldman 2014/03/24 13:41:25 You should not modify the overview, not even when
Pan 2014/03/25 12:30:20 removed.
+
this._eventDividers = [];
this._model = model;
@@ -152,7 +155,9 @@ WebInspector.TimelineOverviewPane.prototype = {
{
if (this._muteOnWindowChanged)
return;
+
var windowTimes = this._overviewControl.windowTimes(this._overviewGrid.windowLeft(), this._overviewGrid.windowRight());
+ this._overviewControl.windowChanged(windowTimes.startTime, windowTimes.endTime);
pfeldman 2014/03/24 13:41:25 Overview control should not be concerned about the
Pan 2014/03/25 12:30:20 Done.
this._windowStartTime = windowTimes.startTime;
this._windowEndTime = windowTimes.endTime;
this.dispatchEventToListeners(WebInspector.TimelineOverviewPane.Events.WindowChanged, windowTimes);
@@ -315,6 +320,11 @@ WebInspector.TimelineOverviewBase.prototype = {
update: function() { },
reset: function() { },
+ startTimeline: function() { },
pfeldman 2014/03/24 13:41:25 These should be called timelineStarted and timelin
Pan 2014/03/25 12:30:20 Done.
+ stopTimeline: function() { },
+
+ windowChanged: function(timeLeft, timeRight) { },
pfeldman 2014/03/24 13:41:25 Overview should not be concerned with the selected
Pan 2014/03/25 06:12:31 The intention is, I'd like to draw the energy cons
Pan 2014/03/25 12:30:20 Done.
+
/**
* @param {number} windowLeft
* @param {number} windowRight

Powered by Google App Engine
This is Rietveld 408576698