Source/devtools/front_end/TimelineFrameController.js - Issue 104523002: [DevTools] Add power profiler and power overview in timeline panel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/TimelineFrameController.js

Issue 104523002: [DevTools] Add power profiler and power overview in timeline panel. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/SettingsScreen.js ('K') | « Source/devtools/front_end/SettingsScreen.js ('k') | Source/devtools/front_end/TimelineModel.js » ('j') | Source/devtools/front_end/TimelineModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/TimelineFrameController.js

diff --git a/Source/devtools/front_end/TimelineFrameController.js b/Source/devtools/front_end/TimelineFrameController.js

index 6a7027484e1e4edaee7ab5642af7be2a50c6330b..78b2122f55fe6b735116ee23363fcf549b200b30 100644

--- a/Source/devtools/front_end/TimelineFrameController.js

+++ b/Source/devtools/front_end/TimelineFrameController.js

@@ -81,6 +81,8 @@ WebInspector.TimelineFrameController.prototype = {

_innerAddRecord: function(programRecord, record)

{

+ if (record.type === WebInspector.TimelineModel.RecordType.SoC_Package)

pfeldman 2014/01/09 11:38:52 You should not skip records of any kind.

Pan 2014/02/24 09:49:47 removed this change

+ return;

var isFrameRecord = record.type === WebInspector.TimelineModel.RecordType.BeginFrame;

var programTimeCarryover = isFrameRecord && programRecord ? WebInspector.TimelineModel.endTimeInSeconds(programRecord) - WebInspector.TimelineModel.startTimeInSeconds(record) : 0;

var lastFrame = record.thread ? this._lastBackgroundFrame : this._lastMainThreadFrame;