Issue 1045173004: Split *_test.gyp from *.gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1045173004: Split _test.gyp from .gyp (Closed)

Created:
5 years, 8 months ago by Mark Mentovai

Modified:
5 years, 8 months ago

Reviewers:
scottmg

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/9e79ea1da71971562f23a147ad220993c633e2fa

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+221 lines, -553 lines)			Patch
M	client/client.gyp	View	1 chunk	+0 lines, -31 lines	0 comments	Download
A +	client/client_test.gyp	View	1 chunk	+2 lines, -51 lines	0 comments	Download
M	crashpad.gyp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	minidump/minidump.gyp	View	1 chunk	+0 lines, -45 lines	0 comments	Download
A +	minidump/minidump_test.gyp	View	1 chunk	+3 lines, -58 lines	0 comments	Download
M	snapshot/snapshot.gyp	View	1 chunk	+0 lines, -91 lines	0 comments	Download
A +	snapshot/snapshot_test.gyp	View	2 chunks	+3 lines, -89 lines	0 comments	Download
M	util/util.gyp	View	1 chunk	+0 lines, -188 lines	0 comments	Download
A	util/util_test.gyp	View	1 chunk	+209 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mark Mentovai

5 years, 8 months ago (2015-03-31 21:06:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9e79ea1da71971562f23a147ad220993c633e2fa (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1045173004: Split *_test.gyp from *.gyp (Closed)

Description

Patch Set 1 #

Messages

Issue 1045173004: Split _test.gyp from .gyp (Closed)