Fix blacklisting for desktop infobars.

components/password_manager/core/browser/password_form_manager.h

Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index 7e3a5e9e4a3e5e1da4ac32d2153a46fc7e1e6a7a..1d0c5cd90daa467080079ea87ca65264662f9900 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -138,7 +138,7 @@ class PasswordFormManager : public PasswordStoreConsumer {
   // A user opted to 'never remember' passwords for this form.
   // Blacklist it so that from now on when it is seen we ignore it.
   // TODO: Make this private once we switch to the new UI.
-  void PermanentlyBlacklist();
+  virtual void PermanentlyBlacklist();

[vabr (Chromium), 2015/04/02 13:32:17]

Please add a TODO at the PasswordFormManager class definition and file a bug for
separating the PasswordFormManager API interface and the implementation in two
classes.
The reason is to make mocking easier (no need to deal with the cumbersome
constructor). This will be some work, and there is no reason to mix that with
this CL, but we should not forget about it.
Please mark the bug with Cr-UI-Browser-Passwords and Hotlist-GoodFirstBug
labels. Thanks!

[melandory, 2015/04/02 15:49:17]

Done.

 
   // If the user has submitted observed_form_, provisionally hold on to
   // the submitted credentials until we are told by PasswordManager whether