Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: tools/skp/webpages_playback.py

Issue 1045153004: Turn on Chromium's top 25 page set (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/skp/webpages_playback.py
diff --git a/tools/skp/webpages_playback.py b/tools/skp/webpages_playback.py
index 7fbb372fd39c6a69373a90b9520ec869cef6bd9a..7f79c4665df38d4419e8bcafe00d32bd8fbbdd90 100644
--- a/tools/skp/webpages_playback.py
+++ b/tools/skp/webpages_playback.py
@@ -121,9 +121,7 @@ CHROMIUM_PAGE_SETS_PATH = os.path.join('tools', 'perf', 'page_sets')
# Dictionary of supported Chromium page sets to their file prefixes.
CHROMIUM_PAGE_SETS_TO_PREFIX = {
'key_mobile_sites_smooth.py': 'keymobi',
- # TODO(rmistry): Uncomment the below after it is verified that the above
- # works.
- # 'top_25_smooth.py': 'top25desk',
+ 'top_25_smooth.py': 'top25desk',
}
@@ -388,10 +386,9 @@ class SkPicturePlayback(object):
# /path/to/http___mobile_news_sandbox_pt0 -> http___mobile_news_sandbox_pt0
_, webpage = os.path.split(site)
# http___mobile_news_sandbox_pt0 -> mobile_news_sandbox_pt0
- if webpage.startswith('http___'):
- webpage = webpage[7:]
- elif webpage.startswith('https___'):
- webpage = webpage[8:]
+ for prefix in ('http___', 'https___'):
+ if webpage.startswith(prefix):
+ webpage = webpage[len(prefix):]
# /path/to/skia_yahooanswers_desktop.py -> skia_yahooanswers_desktop.py
ps_filename = os.path.basename(page_set)
# http___mobile_news_sandbox -> pagesetprefix_http___mobile_news_sandbox
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698