Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6667)

Unified Diff: chrome/test/BUILD.gn

Issue 1045133002: Add performance_tests_browser to the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remoting_targets
Patch Set: make performance_browser_tests properly linux-only for now Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/gn_migration.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index 0eb16d445b1159208d59c14f78774a7a22b49f45..619cf924d934b58bcb4c714d2801ff07ef058fc8 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -1713,38 +1713,45 @@ if (!is_android) {
deps += [ "//third_party/cld_2:cld2_platform_impl" ]
}
}
- # TODO(GYP): Finish me...
- # source_set("performance_browser_tests") {
- # testonly = true
- # sources =
- # rebase_path(chrome_tests_gypi_values.performance_browser_tests_sources,
- # ".",
- # "//chrome")
- # deps = [
- # ":perf",
- # ":test_support",
- # "//base",
- # "//base:i18n",
- # "//base/test:test_support",
- # "//chrome/browser",
- # "//chrome/renderer",
- # "//media/cast:cast_test_utility",
- # "//testing/gtest",
- # ]
- #
- # if (!is_win) {
- # sources -= [
- # "../app/chrome_command_ids.h",
- # # "../app/chrome_dll.rc",
- # #"../app/chrome_dll_resource.h",
- # #"../app/chrome_version.rc.version",
- # ]
- # }
- # if (!is_mac) {
- # sources -= [
- # "perf/mach_ports_performancetest.cc",
- # ]
- # }
- # }
+
+ test("performance_browser_tests") {
+ sources = rebase_path(
+ chrome_tests_gypi_values.performance_browser_tests_sources,
+ ".",
+ "//chrome")
+
+ defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
+
+ deps = [
+ ":test_support",
+ "//base",
+ "//base:i18n",
+ "//base/test:test_support",
+ "//chrome/browser",
+ "//chrome/renderer",
+ "//media/cast:test_support",
+ "//testing/gtest",
+ "//testing/perf",
+ ]
+
+ if (!is_win) {
+ sources -= [
+ "../app/chrome_command_ids.h",
+
+ #"../app/chrome_dll.rc",
+ #"../app/chrome_dll_resource.h",
+ "../app/chrome_version.rc.version",
+ ]
+ }
+ if (!is_mac) {
+ sources -= [ "perf/mach_ports_performancetest.cc" ]
+ }
+
+ if (cld_version == 0 || cld_version == 2) {
+ # Use whatever CLD2 data access mode that the
+ # application embedder is using.
+ deps += [ "//third_party/cld_2:cld2_platform_impl" ]
+ }
+ }
}
}
« no previous file with comments | « build/gn_migration.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698