Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1045133002: Add performance_tests_browser to the GN build. (Closed)

Created:
5 years, 8 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@remoting_targets
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add performance_tests_browser to the GN build. R=brettw@chromium.org BUG=461019 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/76f48222c95e7b00885ab775b95c7eb501ba665d Cr-Commit-Position: refs/heads/master@{#323145}

Patch Set 1 #

Patch Set 2 : merge to #323110 #

Patch Set 3 : do not build performance_browser_tests on mac or android #

Patch Set 4 : make performance_browser_tests properly linux-only for now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -34 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M build/gn_migration.gypi View 1 3 chunks +2 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +40 lines, -33 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Dirk Pranke
5 years, 8 months ago (2015-03-30 22:32:34 UTC) #1
brettw
lgtm
5 years, 8 months ago (2015-03-31 18:10:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045133002/1
5 years, 8 months ago (2015-03-31 19:32:04 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/10411) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-03-31 19:37:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045133002/20001
5 years, 8 months ago (2015-03-31 21:21:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_dbg on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_dbg/builds/259)
5 years, 8 months ago (2015-03-31 21:27:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045133002/40001
5 years, 8 months ago (2015-03-31 21:55:27 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/23026) win8_chromium_gn_rel on tryserver.chromium.win (JOB_FAILED, ...
5 years, 8 months ago (2015-03-31 22:07:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045133002/60001
5 years, 8 months ago (2015-03-31 22:12:44 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-01 00:00:17 UTC) #20
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 00:01:41 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/76f48222c95e7b00885ab775b95c7eb501ba665d
Cr-Commit-Position: refs/heads/master@{#323145}

Powered by Google App Engine
This is Rietveld 408576698