Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 1045123005: Remove indirection of cpufeatures.gypi. (Closed)

Created:
5 years, 8 months ago by Torne
Modified:
5 years, 8 months ago
Reviewers:
Nico, agl, fbarchard, urvang
CC:
chromium-reviews, jzern, vikasa, urvang, skal, jam, darin-cc_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, erikwright+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove indirection of cpufeatures.gypi. Now that android_webview_build is no longer supported, the extra level of indirection of including cpufeatures.gypi instead of directly depending on the cpufeatures target is not necessary. Remove the cases in the Chromium tree. Other references appear in projects pulled in via DEPS that will have to be fixed separately before cpufeatures.gypi can be entirely deleted. BUG=440793 Committed: https://crrev.com/9845b890dd38f0b88b0304f3bd6c437a7c6f8f8d Cr-Commit-Position: refs/heads/master@{#324117}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -42 lines) Patch
M base/base.gyp View 2 chunks +1 line, -3 lines 0 comments Download
M build/android/cpufeatures.gypi View 1 chunk +7 lines, -24 lines 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/content_app.gypi View 1 chunk +1 line, -3 lines 0 comments Download
M content/content_child.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +1 line, -3 lines 0 comments Download
M crypto/crypto.gyp View 1 chunk +3 lines, -3 lines 0 comments Download
M skia/skia_library.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libwebp/libwebp.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Torne
thakis: base/, build/, skia/ agl: crypto/ fbarchard: third_party/libwebp/
5 years, 8 months ago (2015-03-31 13:56:07 UTC) #2
Nico
lgtm
5 years, 8 months ago (2015-03-31 15:24:00 UTC) #3
agl
lgtm
5 years, 8 months ago (2015-03-31 17:45:37 UTC) #4
Torne
+urvang for third_party/libwebp
5 years, 8 months ago (2015-04-07 15:05:44 UTC) #6
urvang
lgtm Rubberstamp LGTM for libwebp
5 years, 8 months ago (2015-04-07 18:22:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045123005/1
5 years, 8 months ago (2015-04-07 20:11:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 21:03:10 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 21:05:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9845b890dd38f0b88b0304f3bd6c437a7c6f8f8d
Cr-Commit-Position: refs/heads/master@{#324117}

Powered by Google App Engine
This is Rietveld 408576698