Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1045123003: Revert of Revert of Add record-as-much-as-possible mode for about://tracing. (Closed)

Created:
5 years, 8 months ago by nednguyen
Modified:
5 years, 8 months ago
Reviewers:
nduca, Nico, Nat
CC:
chromium-reviews, darin-cc_chromium.org, jam, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Add record-as-much-as-possible mode for about://tracing. (patchset #1 id:1 of https://codereview.chromium.org/1043973003/) Reason for revert: Size increase in https://code.google.com/p/chromium/issues/detail?id=471610 is WAI. Original issue's description: > Revert of Add record-as-much-as-possible mode for about://tracing. (patchset #1 id:1 of https://codereview.chromium.org/1033223008/) > > Reason for revert: > Speculative revert to see if this cause 340kb increase in size (BUG=471610 ) > > Original issue's description: > > Add record-as-much-as-possible mode for about://tracing. > > > > Update DEPS for trace-viewer to include the 3 tracing modes selector. > > > > BUG=396081 > > TEST= > > > > Committed: https://crrev.com/8e752353b04c52cb3ba1d54b79fce241c0be53d3 > > Cr-Commit-Position: refs/heads/master@{#322689} > > TBR=nduca@chromium.org,nduca@google.com > > BUG=396081 > > Committed: https://crrev.com/bd28da0bfa3c2105937e61c6fe806c7ba7d43f01 > Cr-Commit-Position: refs/heads/master@{#322853} TBR=nduca@chromium.org,nduca@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=396081 Committed: https://crrev.com/78a183adc6ae3790c242ca1c2cdb39029cffd0c5 Cr-Commit-Position: refs/heads/master@{#322913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/tracing_ui.cc View 1 chunk +5 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nednguyen
Created Revert of Revert of Add record-as-much-as-possible mode for about://tracing.
5 years, 8 months ago (2015-03-30 23:49:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045123003/1
5 years, 8 months ago (2015-03-30 23:50:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-30 23:51:20 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/78a183adc6ae3790c242ca1c2cdb39029cffd0c5 Cr-Commit-Position: refs/heads/master@{#322913}
5 years, 8 months ago (2015-03-30 23:52:19 UTC) #5
Nico
Why was this relanded? This adds 300 kB, this is not WAI. I'll revert this ...
5 years, 8 months ago (2015-03-31 15:43:26 UTC) #7
Nico
5 years, 8 months ago (2015-03-31 15:43:54 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1049283002/ by thakis@chromium.org.

The reason for reverting is: Still causes bloat (crbug.com/471610).

Powered by Google App Engine
This is Rietveld 408576698