Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 104503016: Pass "-std" flag to YCM config. (Closed)

Created:
6 years, 12 months ago by dzhioev (left Google)
Modified:
6 years, 11 months ago
Reviewers:
James Simonsen
CC:
chromium-reviews
Visibility:
Public.

Description

Pass "-std" flag to YCM config. "-std" has value which is not equal to default value "c++11" for some variants of Chrome build. At least for "chromeos=1 clang=1" build "-std=gnu++11" is set. So not passing "-std" to YCM caused compilation error inside YCM, hence there were some problems with completion. BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools/vim/chromium.ycm_extra_conf.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dzhioev (left Google)
6 years, 12 months ago (2013-12-25 16:55:47 UTC) #1
James Simonsen
lgtm
6 years, 11 months ago (2014-01-02 18:40:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/104503016/1
6 years, 11 months ago (2014-01-09 12:20:51 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 12:21:38 UTC) #4
Message was sent while issue was closed.
Change committed as 243862

Powered by Google App Engine
This is Rietveld 408576698