Issue 104503006: Sync DOMImplementation IDL with spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 104503006: Sync DOMImplementation IDL with spec (Closed)

Created:
7 years ago by philipj_slow

Modified:
7 years ago

Reviewers:
arv (Not doing code reviews), jochen (gone - plz use gerrit)

CC:
blink-reviews, arv+blink, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Sync DOMImplementation IDL with spec http://dom.spec.whatwg.org/#domimplementation The new tests pass in Firefox Nightly and Opera 12.16. IE11 Release Preview returns null for doctype.publicId and doctype.systemId, and does not throw an exception when calling hasFeature with only 1 argument, but otherwise passes. Finally, no other browser appears to implement createCSSStyleSheet, so add a UseCounter in the hope that it can be removed. BUG=310298, 325922 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163544

Patch Set 1 #

Patch Set 2 : update test #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -12 lines)			Patch
M	LayoutTests/dom/xhtml/level3/core/documentgetdoctype01.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	LayoutTests/fast/dom/DOMImplementation/createDocumentType-null.html	View		1 chunk	+14 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/DOMImplementation/createDocumentType-null-expected.txt	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/DOMImplementation/missing-arguments.html	View		1 chunk	+22 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/DOMImplementation/missing-arguments-expected.txt	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	Source/core/dom/DOMImplementation.idl	View		1 chunk	+10 lines, -11 lines	0 comments	Download
M	Source/core/frame/UseCounter.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/104503006/20001

7 years ago (2013-12-10 15:58:52 UTC) #3

Message was sent while issue was closed.

Change committed as 163544

Expand Messages | Collapse Messages