Issue 1044943003: Stop linking in desktop/main.cc into the Android build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1044943003: Stop linking in desktop/main.cc into the Android build. (Closed)

Created:
5 years, 8 months ago by viettrungluu

Modified:
5 years, 8 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	shell/BUILD.gn	View		2 chunks	+4 lines, -4 lines	0 comments	Download
	M	shell/android/main.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

viettrungluu

We have good test coverage, right? (Note: I structured the if/else the way I did, ...

5 years, 8 months ago (2015-03-30 20:19:52 UTC) #1

viettrungluu

5 years, 8 months ago (2015-03-30 20:33:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f9f70079f3554827b7aa36728bd9171f4bd97386 (presubmit successful).