Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: chrome/browser/prefs/pref_service_browsertest.cc

Issue 104493005: Update some uses of Value in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/pref_service_browsertest.cc
diff --git a/chrome/browser/prefs/pref_service_browsertest.cc b/chrome/browser/prefs/pref_service_browsertest.cc
index 959e1624d24d6ed82fbc499e77eaa302f19fea38..f5249815f61c366402271d8ed543e8cc1db1a197 100644
--- a/chrome/browser/prefs/pref_service_browsertest.cc
+++ b/chrome/browser/prefs/pref_service_browsertest.cc
@@ -128,12 +128,13 @@ IN_PROC_BROWSER_TEST_F(PreservedWindowPlacementIsLoaded, Test) {
// The window should open with the new reference profile, with window
// placement values stored in the user data directory.
JSONFileValueSerializer deserializer(tmp_pref_file_);
- scoped_ptr<Value> root(deserializer.Deserialize(NULL, NULL));
+ scoped_ptr<base::Value> root(deserializer.Deserialize(NULL, NULL));
ASSERT_TRUE(root.get());
- ASSERT_TRUE(root->IsType(Value::TYPE_DICTIONARY));
+ ASSERT_TRUE(root->IsType(base::Value::TYPE_DICTIONARY));
- DictionaryValue* root_dict = static_cast<DictionaryValue*>(root.get());
+ base::DictionaryValue* root_dict =
+ static_cast<base::DictionaryValue*>(root.get());
// Retrieve the screen rect for the launched window
gfx::Rect bounds = browser()->window()->GetRestoredBounds();
@@ -188,10 +189,10 @@ IN_PROC_BROWSER_TEST_F(PreservedWindowPlacementIsMigrated, Test) {
// placement values stored in Local State.
JSONFileValueSerializer deserializer(tmp_pref_file_);
- scoped_ptr<Value> root(deserializer.Deserialize(NULL, NULL));
+ scoped_ptr<base::Value> root(deserializer.Deserialize(NULL, NULL));
ASSERT_TRUE(root.get());
- ASSERT_TRUE(root->IsType(Value::TYPE_DICTIONARY));
+ ASSERT_TRUE(root->IsType(base::Value::TYPE_DICTIONARY));
// Retrieve the screen rect for the launched window
gfx::Rect bounds = browser()->window()->GetRestoredBounds();
@@ -199,7 +200,8 @@ IN_PROC_BROWSER_TEST_F(PreservedWindowPlacementIsMigrated, Test) {
// Values from old reference profile in Local State should have been
// correctly migrated to the user's Preferences -- if so, the window
// should be set to values taken from the user's Local State.
- DictionaryValue* root_dict = static_cast<DictionaryValue*>(root.get());
+ base::DictionaryValue* root_dict =
+ static_cast<base::DictionaryValue*>(root.get());
// Retrieve the expected rect values from User Preferences, where they
// should have been migrated from Local State.
« no previous file with comments | « chrome/browser/prefs/pref_model_associator_unittest.cc ('k') | chrome/browser/prefs/proxy_config_dictionary.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698