Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1496)

Unified Diff: chrome/browser/net/ssl_config_service_manager_pref_unittest.cc

Issue 104493005: Update some uses of Value in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/ssl_config_service_manager_pref_unittest.cc
diff --git a/chrome/browser/net/ssl_config_service_manager_pref_unittest.cc b/chrome/browser/net/ssl_config_service_manager_pref_unittest.cc
index 70b1175e381f91113f2d95f89bb9cc6fd2898a65..2cbfc05b45321adcc0a3d3b6c4dfd7f55bdeda94 100644
--- a/chrome/browser/net/ssl_config_service_manager_pref_unittest.cc
+++ b/chrome/browser/net/ssl_config_service_manager_pref_unittest.cc
@@ -53,7 +53,7 @@ TEST_F(SSLConfigServiceManagerPrefTest, ChannelIDWithoutUserPrefs) {
TestingPrefServiceSimple local_state;
SSLConfigServiceManager::RegisterPrefs(local_state.registry());
local_state.SetUserPref(prefs::kEnableOriginBoundCerts,
- Value::CreateBooleanValue(false));
+ base::Value::CreateBooleanValue(false));
scoped_ptr<SSLConfigServiceManager> config_manager(
SSLConfigServiceManager::CreateDefaultManager(&local_state));
@@ -66,7 +66,7 @@ TEST_F(SSLConfigServiceManagerPrefTest, ChannelIDWithoutUserPrefs) {
EXPECT_FALSE(config.channel_id_enabled);
local_state.SetUserPref(prefs::kEnableOriginBoundCerts,
- Value::CreateBooleanValue(true));
+ base::Value::CreateBooleanValue(true));
// Pump the message loop to notify the SSLConfigServiceManagerPref that the
// preferences changed.
message_loop_.RunUntilIdle();
@@ -90,9 +90,9 @@ TEST_F(SSLConfigServiceManagerPrefTest, GoodDisabledCipherSuites) {
config_service->GetSSLConfig(&old_config);
EXPECT_TRUE(old_config.disabled_cipher_suites.empty());
- ListValue* list_value = new ListValue();
- list_value->Append(Value::CreateStringValue("0x0004"));
- list_value->Append(Value::CreateStringValue("0x0005"));
+ base::ListValue* list_value = new base::ListValue();
+ list_value->Append(base::Value::CreateStringValue("0x0004"));
+ list_value->Append(base::Value::CreateStringValue("0x0005"));
local_state.SetUserPref(prefs::kCipherSuiteBlacklist, list_value);
// Pump the message loop to notify the SSLConfigServiceManagerPref that the
@@ -125,11 +125,12 @@ TEST_F(SSLConfigServiceManagerPrefTest, BadDisabledCipherSuites) {
config_service->GetSSLConfig(&old_config);
EXPECT_TRUE(old_config.disabled_cipher_suites.empty());
- ListValue* list_value = new ListValue();
- list_value->Append(Value::CreateStringValue("0x0004"));
- list_value->Append(Value::CreateStringValue("TLS_NOT_WITH_A_CIPHER_SUITE"));
- list_value->Append(Value::CreateStringValue("0x0005"));
- list_value->Append(Value::CreateStringValue("0xBEEFY"));
+ base::ListValue* list_value = new base::ListValue();
+ list_value->Append(base::Value::CreateStringValue("0x0004"));
+ list_value->Append(
+ base::Value::CreateStringValue("TLS_NOT_WITH_A_CIPHER_SUITE"));
+ list_value->Append(base::Value::CreateStringValue("0x0005"));
+ list_value->Append(base::Value::CreateStringValue("0xBEEFY"));
local_state.SetUserPref(prefs::kCipherSuiteBlacklist, list_value);
// Pump the message loop to notify the SSLConfigServiceManagerPref that the
« no previous file with comments | « chrome/browser/net/ssl_config_service_manager_pref.cc ('k') | chrome/browser/network_time/network_time_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698