chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest.cc - Issue 104493005: Update some uses of Value in chrome/browser to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest.cc

Issue 104493005: Update some uses of Value in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/spdyproxy/data_reduction_proxy_settings.cc ('k') | chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest.cc

diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest.cc b/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest.cc

index c4dd52b66793bea243664b02822440b00c285a9b..b63276866cfa8dd90fa4d69bed3704e47c8c2ab2 100644

--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest.cc

+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest.cc

@@ -83,8 +83,9 @@ void DataReductionProxySettingsTestBase::SetUp() {

ListPrefUpdate received_update(&pref_service_,

prefs::kDailyHttpReceivedContentLength);

for (int64 i = 0; i < spdyproxy::kNumDaysInHistory; i++) {

- original_update->Insert(0, new StringValue(base::Int64ToString(2 * i)));

- received_update->Insert(0, new StringValue(base::Int64ToString(i)));

+ original_update->Insert(0,

+ new base::StringValue(base::Int64ToString(2 * i)));

+ received_update->Insert(0, new base::StringValue(base::Int64ToString(i)));

}

last_update_time_ = base::Time::Now().LocalMidnight();

pref_service_.SetInt64(

@@ -154,7 +155,8 @@ DataReductionProxySettingsTestBase::SetProbeResult<

void DataReductionProxySettingsTestBase::CheckProxyPref(

const std::string& expected_servers,

const std::string& expected_mode) {

- const DictionaryValue* dict = pref_service_.GetDictionary(prefs::kProxy);

+ const base::DictionaryValue* dict =

+ pref_service_.GetDictionary(prefs::kProxy);

std::string mode;

std::string server;

dict->GetString("mode", &mode);