Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3303)

Unified Diff: chrome/browser/net/firefox_proxy_settings.cc

Issue 104493005: Update some uses of Value in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/chrome_network_delegate.cc ('k') | chrome/browser/net/gaia/gaia_oauth_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/firefox_proxy_settings.cc
diff --git a/chrome/browser/net/firefox_proxy_settings.cc b/chrome/browser/net/firefox_proxy_settings.cc
index 9df1dda5badb2132088995608eb5b679d858f2f0..2ac04383badc657b42853fd26ee94f33448cfebe 100644
--- a/chrome/browser/net/firefox_proxy_settings.cc
+++ b/chrome/browser/net/firefox_proxy_settings.cc
@@ -65,7 +65,8 @@ FirefoxProxySettings::SOCKSVersion IntToSOCKSVersion(int type) {
// |prefs| is not filled).
// Note: for strings, only valid UTF-8 string values are supported. If a
// key/pair is not valid UTF-8, it is ignored and will not appear in |prefs|.
-bool ParsePrefFile(const base::FilePath& pref_file, DictionaryValue* prefs) {
+bool ParsePrefFile(const base::FilePath& pref_file,
+ base::DictionaryValue* prefs) {
// The string that is before a pref key.
const std::string kUserPrefString = "user_pref(\"";
std::string contents;
@@ -245,7 +246,7 @@ bool FirefoxProxySettings::ToProxyConfig(net::ProxyConfig* config) {
// static
bool FirefoxProxySettings::GetSettingsFromFile(const base::FilePath& pref_file,
FirefoxProxySettings* settings) {
- DictionaryValue dictionary;
+ base::DictionaryValue dictionary;
if (!ParsePrefFile(pref_file, &dictionary))
return false;
« no previous file with comments | « chrome/browser/net/chrome_network_delegate.cc ('k') | chrome/browser/net/gaia/gaia_oauth_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698