Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 104493005: Update some uses of Value in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/metrics_log_unittest.cc ('k') | chrome/browser/net/chrome_network_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_service.cc
diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc
index 8c008d7976a51ba2c3ebf495b2ca53217d722229..d220080caf2d4b05f706d70f4325aa5fb50844cd 100644
--- a/chrome/browser/metrics/metrics_service.cc
+++ b/chrome/browser/metrics/metrics_service.cc
@@ -1888,17 +1888,18 @@ MetricsService::ChildProcessStats& MetricsService::GetChildProcessStats(
void MetricsService::RecordPluginChanges(PrefService* pref) {
ListPrefUpdate update(pref, prefs::kStabilityPluginStats);
- ListValue* plugins = update.Get();
+ base::ListValue* plugins = update.Get();
DCHECK(plugins);
- for (ListValue::iterator value_iter = plugins->begin();
+ for (base::ListValue::iterator value_iter = plugins->begin();
value_iter != plugins->end(); ++value_iter) {
- if (!(*value_iter)->IsType(Value::TYPE_DICTIONARY)) {
+ if (!(*value_iter)->IsType(base::Value::TYPE_DICTIONARY)) {
NOTREACHED();
continue;
}
- DictionaryValue* plugin_dict = static_cast<DictionaryValue*>(*value_iter);
+ base::DictionaryValue* plugin_dict =
+ static_cast<base::DictionaryValue*>(*value_iter);
std::string plugin_name;
plugin_dict->GetString(prefs::kStabilityPluginName, &plugin_name);
if (plugin_name.empty()) {
@@ -1958,7 +1959,7 @@ void MetricsService::RecordPluginChanges(PrefService* pref) {
// TODO(viettrungluu): remove conversion
std::string plugin_name = UTF16ToUTF8(cache_iter->first);
- DictionaryValue* plugin_dict = new DictionaryValue;
+ base::DictionaryValue* plugin_dict = new base::DictionaryValue;
plugin_dict->SetString(prefs::kStabilityPluginName, plugin_name);
plugin_dict->SetInteger(prefs::kStabilityPluginLaunches,
« no previous file with comments | « chrome/browser/metrics/metrics_log_unittest.cc ('k') | chrome/browser/net/chrome_network_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698