Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5242)

Unified Diff: chrome/browser/history/most_visited_tiles_experiment_unittest.cc

Issue 104493005: Update some uses of Value in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/guestview/webview/webview_guest.cc ('k') | chrome/browser/history/top_sites_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/most_visited_tiles_experiment_unittest.cc
diff --git a/chrome/browser/history/most_visited_tiles_experiment_unittest.cc b/chrome/browser/history/most_visited_tiles_experiment_unittest.cc
index ccaee6fbef816969382afc1539aed49015f6dd5f..309d0f01216661dfd23eb294d171845e6d920ee9 100644
--- a/chrome/browser/history/most_visited_tiles_experiment_unittest.cc
+++ b/chrome/browser/history/most_visited_tiles_experiment_unittest.cc
@@ -46,7 +46,7 @@ enum FlippedIndexes {
// Creates a DictionaryValue using |url| and appends to |list|.
void AppendURLToListValue(const std::string& url_string,
base::ListValue* list) {
- DictionaryValue* page_value = new DictionaryValue();
+ base::DictionaryValue* page_value = new base::DictionaryValue();
page_value->SetString("url", url_string);
list->Append(page_value);
}
@@ -160,7 +160,7 @@ TEST_F(MostVisitedTilesExperimentTest,
// Test the method when there are not enough URLs to force removal.
MostVisitedTilesExperiment::RemovePageValuesMatchingOpenTabs(
open_urls, &pages_value);
- DictionaryValue gmail_value;
+ base::DictionaryValue gmail_value;
gmail_value.SetString("url", kGmailURL);
// Ensure the open url has not been removed from |pages_value|.
EXPECT_NE(pages_value.end(), pages_value.Find(gmail_value));
@@ -196,7 +196,7 @@ TEST_F(MostVisitedTilesExperimentTest, RemovePageValuesMatchingOpenTabs) {
MostVisitedTilesExperiment::RemovePageValuesMatchingOpenTabs(
open_urls, &pages_value);
// Ensure the open url has been removed from |pages_value|.
- DictionaryValue gmail_value;
+ base::DictionaryValue gmail_value;
gmail_value.SetString("url", kGmailURL);
EXPECT_EQ(pages_value.end(), pages_value.Find(gmail_value));
« no previous file with comments | « chrome/browser/guestview/webview/webview_guest.cc ('k') | chrome/browser/history/top_sites_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698