Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: chrome/browser/prefs/incognito_mode_prefs_unittest.cc

Issue 104493005: Update some uses of Value in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prefs/incognito_mode_prefs.h" 5 #include "chrome/browser/prefs/incognito_mode_prefs.h"
6 6
7 #include "chrome/common/pref_names.h" 7 #include "chrome/common/pref_names.h"
8 #include "chrome/test/base/testing_pref_service_syncable.h" 8 #include "chrome/test/base/testing_pref_service_syncable.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 20 matching lines...) Expand all
31 EXPECT_EQ(IncognitoModePrefs::FORCED, incognito); 31 EXPECT_EQ(IncognitoModePrefs::FORCED, incognito);
32 32
33 EXPECT_FALSE(IncognitoModePrefs::IntToAvailability(10, &incognito)); 33 EXPECT_FALSE(IncognitoModePrefs::IntToAvailability(10, &incognito));
34 EXPECT_EQ(IncognitoModePrefs::ENABLED, incognito); 34 EXPECT_EQ(IncognitoModePrefs::ENABLED, incognito);
35 EXPECT_FALSE(IncognitoModePrefs::IntToAvailability(-1, &incognito)); 35 EXPECT_FALSE(IncognitoModePrefs::IntToAvailability(-1, &incognito));
36 EXPECT_EQ(IncognitoModePrefs::ENABLED, incognito); 36 EXPECT_EQ(IncognitoModePrefs::ENABLED, incognito);
37 } 37 }
38 38
39 TEST_F(IncognitoModePrefsTest, GetAvailability) { 39 TEST_F(IncognitoModePrefsTest, GetAvailability) {
40 prefs_.SetUserPref(prefs::kIncognitoModeAvailability, 40 prefs_.SetUserPref(prefs::kIncognitoModeAvailability,
41 Value::CreateIntegerValue(IncognitoModePrefs::ENABLED)); 41 base::Value::CreateIntegerValue(
42 IncognitoModePrefs::ENABLED));
42 EXPECT_EQ(IncognitoModePrefs::ENABLED, 43 EXPECT_EQ(IncognitoModePrefs::ENABLED,
43 IncognitoModePrefs::GetAvailability(&prefs_)); 44 IncognitoModePrefs::GetAvailability(&prefs_));
44 45
45 prefs_.SetUserPref(prefs::kIncognitoModeAvailability, 46 prefs_.SetUserPref(prefs::kIncognitoModeAvailability,
46 Value::CreateIntegerValue(IncognitoModePrefs::DISABLED)); 47 base::Value::CreateIntegerValue(
48 IncognitoModePrefs::DISABLED));
47 EXPECT_EQ(IncognitoModePrefs::DISABLED, 49 EXPECT_EQ(IncognitoModePrefs::DISABLED,
48 IncognitoModePrefs::GetAvailability(&prefs_)); 50 IncognitoModePrefs::GetAvailability(&prefs_));
49 51
50 prefs_.SetUserPref(prefs::kIncognitoModeAvailability, 52 prefs_.SetUserPref(prefs::kIncognitoModeAvailability,
51 Value::CreateIntegerValue(IncognitoModePrefs::FORCED)); 53 base::Value::CreateIntegerValue(
54 IncognitoModePrefs::FORCED));
52 EXPECT_EQ(IncognitoModePrefs::FORCED, 55 EXPECT_EQ(IncognitoModePrefs::FORCED,
53 IncognitoModePrefs::GetAvailability(&prefs_)); 56 IncognitoModePrefs::GetAvailability(&prefs_));
54 } 57 }
55 58
56 typedef IncognitoModePrefsTest IncognitoModePrefsDeathTest; 59 typedef IncognitoModePrefsTest IncognitoModePrefsDeathTest;
57 60
58 // Takes too long to execute on Mac. http://crbug.com/101109 61 // Takes too long to execute on Mac. http://crbug.com/101109
59 #if defined(OS_MACOSX) 62 #if defined(OS_MACOSX)
60 #define MAYBE_GetAvailabilityBadValue DISABLED_GetAvailabilityBadValue 63 #define MAYBE_GetAvailabilityBadValue DISABLED_GetAvailabilityBadValue
61 #else 64 #else
62 #define MAYBE_GetAvailabilityBadValue GetAvailabilityBadValue 65 #define MAYBE_GetAvailabilityBadValue GetAvailabilityBadValue
63 #endif 66 #endif
64 67
65 #if GTEST_HAS_DEATH_TEST 68 #if GTEST_HAS_DEATH_TEST
66 TEST_F(IncognitoModePrefsDeathTest, MAYBE_GetAvailabilityBadValue) { 69 TEST_F(IncognitoModePrefsDeathTest, MAYBE_GetAvailabilityBadValue) {
67 prefs_.SetUserPref(prefs::kIncognitoModeAvailability, 70 prefs_.SetUserPref(prefs::kIncognitoModeAvailability,
68 Value::CreateIntegerValue(-1)); 71 base::Value::CreateIntegerValue(-1));
69 #if defined(NDEBUG) && defined(DCHECK_ALWAYS_ON) 72 #if defined(NDEBUG) && defined(DCHECK_ALWAYS_ON)
70 EXPECT_DEATH({ 73 EXPECT_DEATH({
71 IncognitoModePrefs::Availability availability = 74 IncognitoModePrefs::Availability availability =
72 IncognitoModePrefs::GetAvailability(&prefs_); 75 IncognitoModePrefs::GetAvailability(&prefs_);
73 EXPECT_EQ(IncognitoModePrefs::ENABLED, availability); 76 EXPECT_EQ(IncognitoModePrefs::ENABLED, availability);
74 }, ""); 77 }, "");
75 #else 78 #else
76 EXPECT_DEBUG_DEATH({ 79 EXPECT_DEBUG_DEATH({
77 IncognitoModePrefs::Availability availability = 80 IncognitoModePrefs::Availability availability =
78 IncognitoModePrefs::GetAvailability(&prefs_); 81 IncognitoModePrefs::GetAvailability(&prefs_);
79 EXPECT_EQ(IncognitoModePrefs::ENABLED, availability); 82 EXPECT_EQ(IncognitoModePrefs::ENABLED, availability);
80 }, ""); 83 }, "");
81 #endif 84 #endif
82 } 85 }
83 #endif // GTEST_HAS_DEATH_TEST 86 #endif // GTEST_HAS_DEATH_TEST
OLDNEW
« no previous file with comments | « chrome/browser/prefs/command_line_pref_store_unittest.cc ('k') | chrome/browser/prefs/pref_metrics_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698