Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: chrome/browser/prefs/command_line_pref_store_unittest.cc

Issue 104493005: Update some uses of Value in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <gtest/gtest.h> 5 #include <gtest/gtest.h>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 13 matching lines...) Expand all
24 class TestCommandLinePrefStore : public CommandLinePrefStore { 24 class TestCommandLinePrefStore : public CommandLinePrefStore {
25 public: 25 public:
26 explicit TestCommandLinePrefStore(CommandLine* cl) 26 explicit TestCommandLinePrefStore(CommandLine* cl)
27 : CommandLinePrefStore(cl) {} 27 : CommandLinePrefStore(cl) {}
28 28
29 bool ProxySwitchesAreValid() { 29 bool ProxySwitchesAreValid() {
30 return ValidateProxySwitches(); 30 return ValidateProxySwitches();
31 } 31 }
32 32
33 void VerifyProxyMode(ProxyPrefs::ProxyMode expected_mode) { 33 void VerifyProxyMode(ProxyPrefs::ProxyMode expected_mode) {
34 const Value* value = NULL; 34 const base::Value* value = NULL;
35 ASSERT_TRUE(GetValue(prefs::kProxy, &value)); 35 ASSERT_TRUE(GetValue(prefs::kProxy, &value));
36 ASSERT_EQ(Value::TYPE_DICTIONARY, value->GetType()); 36 ASSERT_EQ(base::Value::TYPE_DICTIONARY, value->GetType());
37 ProxyConfigDictionary dict(static_cast<const DictionaryValue*>(value)); 37 ProxyConfigDictionary dict(
38 static_cast<const base::DictionaryValue*>(value));
38 ProxyPrefs::ProxyMode actual_mode; 39 ProxyPrefs::ProxyMode actual_mode;
39 ASSERT_TRUE(dict.GetMode(&actual_mode)); 40 ASSERT_TRUE(dict.GetMode(&actual_mode));
40 EXPECT_EQ(expected_mode, actual_mode); 41 EXPECT_EQ(expected_mode, actual_mode);
41 } 42 }
42 43
43 void VerifySSLCipherSuites(const char* const* ciphers, 44 void VerifySSLCipherSuites(const char* const* ciphers,
44 size_t cipher_count) { 45 size_t cipher_count) {
45 const Value* value = NULL; 46 const base::Value* value = NULL;
46 ASSERT_TRUE(GetValue(prefs::kCipherSuiteBlacklist, &value)); 47 ASSERT_TRUE(GetValue(prefs::kCipherSuiteBlacklist, &value));
47 ASSERT_EQ(Value::TYPE_LIST, value->GetType()); 48 ASSERT_EQ(base::Value::TYPE_LIST, value->GetType());
48 const ListValue* list_value = static_cast<const ListValue*>(value); 49 const base::ListValue* list_value =
50 static_cast<const base::ListValue*>(value);
49 ASSERT_EQ(cipher_count, list_value->GetSize()); 51 ASSERT_EQ(cipher_count, list_value->GetSize());
50 52
51 std::string cipher_string; 53 std::string cipher_string;
52 for (ListValue::const_iterator it = list_value->begin(); 54 for (base::ListValue::const_iterator it = list_value->begin();
53 it != list_value->end(); ++it, ++ciphers) { 55 it != list_value->end(); ++it, ++ciphers) {
54 ASSERT_TRUE((*it)->GetAsString(&cipher_string)); 56 ASSERT_TRUE((*it)->GetAsString(&cipher_string));
55 EXPECT_EQ(*ciphers, cipher_string); 57 EXPECT_EQ(*ciphers, cipher_string);
56 } 58 }
57 } 59 }
58 60
59 private: 61 private:
60 virtual ~TestCommandLinePrefStore() {} 62 virtual ~TestCommandLinePrefStore() {}
61 }; 63 };
62 64
63 // Tests a simple string pref on the command line. 65 // Tests a simple string pref on the command line.
64 TEST(CommandLinePrefStoreTest, SimpleStringPref) { 66 TEST(CommandLinePrefStoreTest, SimpleStringPref) {
65 CommandLine cl(CommandLine::NO_PROGRAM); 67 CommandLine cl(CommandLine::NO_PROGRAM);
66 cl.AppendSwitchASCII(switches::kLang, "hi-MOM"); 68 cl.AppendSwitchASCII(switches::kLang, "hi-MOM");
67 scoped_refptr<CommandLinePrefStore> store = new CommandLinePrefStore(&cl); 69 scoped_refptr<CommandLinePrefStore> store = new CommandLinePrefStore(&cl);
68 70
69 const Value* actual = NULL; 71 const base::Value* actual = NULL;
70 EXPECT_TRUE(store->GetValue(prefs::kApplicationLocale, &actual)); 72 EXPECT_TRUE(store->GetValue(prefs::kApplicationLocale, &actual));
71 std::string result; 73 std::string result;
72 EXPECT_TRUE(actual->GetAsString(&result)); 74 EXPECT_TRUE(actual->GetAsString(&result));
73 EXPECT_EQ("hi-MOM", result); 75 EXPECT_EQ("hi-MOM", result);
74 } 76 }
75 77
76 // Tests a simple boolean pref on the command line. 78 // Tests a simple boolean pref on the command line.
77 TEST(CommandLinePrefStoreTest, SimpleBooleanPref) { 79 TEST(CommandLinePrefStoreTest, SimpleBooleanPref) {
78 CommandLine cl(CommandLine::NO_PROGRAM); 80 CommandLine cl(CommandLine::NO_PROGRAM);
79 cl.AppendSwitch(switches::kNoProxyServer); 81 cl.AppendSwitch(switches::kNoProxyServer);
80 scoped_refptr<TestCommandLinePrefStore> store = 82 scoped_refptr<TestCommandLinePrefStore> store =
81 new TestCommandLinePrefStore(&cl); 83 new TestCommandLinePrefStore(&cl);
82 84
83 store->VerifyProxyMode(ProxyPrefs::MODE_DIRECT); 85 store->VerifyProxyMode(ProxyPrefs::MODE_DIRECT);
84 } 86 }
85 87
86 // Tests a command line with no recognized prefs. 88 // Tests a command line with no recognized prefs.
87 TEST(CommandLinePrefStoreTest, NoPrefs) { 89 TEST(CommandLinePrefStoreTest, NoPrefs) {
88 CommandLine cl(CommandLine::NO_PROGRAM); 90 CommandLine cl(CommandLine::NO_PROGRAM);
89 cl.AppendSwitch(unknown_string); 91 cl.AppendSwitch(unknown_string);
90 cl.AppendSwitchASCII(unknown_bool, "a value"); 92 cl.AppendSwitchASCII(unknown_bool, "a value");
91 scoped_refptr<CommandLinePrefStore> store = new CommandLinePrefStore(&cl); 93 scoped_refptr<CommandLinePrefStore> store = new CommandLinePrefStore(&cl);
92 94
93 const Value* actual = NULL; 95 const base::Value* actual = NULL;
94 EXPECT_FALSE(store->GetValue(unknown_bool, &actual)); 96 EXPECT_FALSE(store->GetValue(unknown_bool, &actual));
95 EXPECT_FALSE(store->GetValue(unknown_string, &actual)); 97 EXPECT_FALSE(store->GetValue(unknown_string, &actual));
96 } 98 }
97 99
98 // Tests a complex command line with multiple known and unknown switches. 100 // Tests a complex command line with multiple known and unknown switches.
99 TEST(CommandLinePrefStoreTest, MultipleSwitches) { 101 TEST(CommandLinePrefStoreTest, MultipleSwitches) {
100 CommandLine cl(CommandLine::NO_PROGRAM); 102 CommandLine cl(CommandLine::NO_PROGRAM);
101 cl.AppendSwitch(unknown_string); 103 cl.AppendSwitch(unknown_string);
102 cl.AppendSwitchASCII(switches::kProxyServer, "proxy"); 104 cl.AppendSwitchASCII(switches::kProxyServer, "proxy");
103 cl.AppendSwitchASCII(switches::kProxyBypassList, "list"); 105 cl.AppendSwitchASCII(switches::kProxyBypassList, "list");
104 cl.AppendSwitchASCII(unknown_bool, "a value"); 106 cl.AppendSwitchASCII(unknown_bool, "a value");
105 scoped_refptr<TestCommandLinePrefStore> store = 107 scoped_refptr<TestCommandLinePrefStore> store =
106 new TestCommandLinePrefStore(&cl); 108 new TestCommandLinePrefStore(&cl);
107 109
108 const Value* actual = NULL; 110 const base::Value* actual = NULL;
109 EXPECT_FALSE(store->GetValue(unknown_bool, &actual)); 111 EXPECT_FALSE(store->GetValue(unknown_bool, &actual));
110 EXPECT_FALSE(store->GetValue(unknown_string, &actual)); 112 EXPECT_FALSE(store->GetValue(unknown_string, &actual));
111 113
112 store->VerifyProxyMode(ProxyPrefs::MODE_FIXED_SERVERS); 114 store->VerifyProxyMode(ProxyPrefs::MODE_FIXED_SERVERS);
113 115
114 const Value* value = NULL; 116 const base::Value* value = NULL;
115 ASSERT_TRUE(store->GetValue(prefs::kProxy, &value)); 117 ASSERT_TRUE(store->GetValue(prefs::kProxy, &value));
116 ASSERT_EQ(Value::TYPE_DICTIONARY, value->GetType()); 118 ASSERT_EQ(base::Value::TYPE_DICTIONARY, value->GetType());
117 ProxyConfigDictionary dict(static_cast<const DictionaryValue*>(value)); 119 ProxyConfigDictionary dict(static_cast<const base::DictionaryValue*>(value));
118 120
119 std::string string_result; 121 std::string string_result;
120 122
121 ASSERT_TRUE(dict.GetProxyServer(&string_result)); 123 ASSERT_TRUE(dict.GetProxyServer(&string_result));
122 EXPECT_EQ("proxy", string_result); 124 EXPECT_EQ("proxy", string_result);
123 125
124 ASSERT_TRUE(dict.GetBypassList(&string_result)); 126 ASSERT_TRUE(dict.GetBypassList(&string_result));
125 EXPECT_EQ("list", string_result); 127 EXPECT_EQ("list", string_result);
126 } 128 }
127 129
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 cl3.AppendSwitchASCII(switches::kCipherSuiteBlacklist, 210 cl3.AppendSwitchASCII(switches::kCipherSuiteBlacklist,
209 "0x0004;MOAR;0x0005"); 211 "0x0004;MOAR;0x0005");
210 scoped_refptr<TestCommandLinePrefStore> store3 = 212 scoped_refptr<TestCommandLinePrefStore> store3 =
211 new TestCommandLinePrefStore(&cl3); 213 new TestCommandLinePrefStore(&cl3);
212 const char* const expected_ciphers3[] = { 214 const char* const expected_ciphers3[] = {
213 "0x0004;MOAR;0x0005" 215 "0x0004;MOAR;0x0005"
214 }; 216 };
215 store3->VerifySSLCipherSuites(expected_ciphers3, 217 store3->VerifySSLCipherSuites(expected_ciphers3,
216 arraysize(expected_ciphers3)); 218 arraysize(expected_ciphers3));
217 } 219 }
OLDNEW
« no previous file with comments | « chrome/browser/prefs/command_line_pref_store.cc ('k') | chrome/browser/prefs/incognito_mode_prefs_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698