Remove wchar/wstring version of StringPrintf.

chrome/browser/browser_keyevents_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/stringprintf.h"
@@ skipping 14 matching lines @@
 #include "net/test/test_server.h"
 #include "ui/base/keycodes/keyboard_codes.h"
 
 using content::DomOperationNotificationDetails;
 using content::NavigationController;
 using content::RenderViewHost;
 
 namespace {
 
 const char kTestingPage[] = "files/keyevents_test.html";
-const wchar_t kSuppressEventJS[] =
-    L"window.domAutomationController.send(setDefaultAction('%ls', %ls));";
-const wchar_t kGetResultJS[] =
-    L"window.domAutomationController.send(keyEventResult[%d]);";
+const char kSuppressEventJS[] =
+    "window.domAutomationController.send(setDefaultAction('%s', %s));";
+const char kGetResultJS[] =
+    "window.domAutomationController.send(keyEventResult[%d]);";
 const wchar_t kGetResultLengthJS[] =
     L"window.domAutomationController.send(keyEventResult.length);";
 const wchar_t kGetFocusedElementJS[] =
     L"window.domAutomationController.send(focusedElement);";
-const wchar_t kSetFocusedElementJS[] =
-    L"window.domAutomationController.send(setFocusedElement('%ls'));";
-const wchar_t kGetTextBoxValueJS[] =
-    L"window.domAutomationController.send("
-    L"document.getElementById('%ls').value);";
-const wchar_t kSetTextBoxValueJS[] =
-    L"window.domAutomationController.send("
-    L"document.getElementById('%ls').value = '%ls');";
-const wchar_t kStartTestJS[] =
-    L"window.domAutomationController.send(startTest(%d));";
+const char kSetFocusedElementJS[] =
+    "window.domAutomationController.send(setFocusedElement('%s'));";
+const char kGetTextBoxValueJS[] =
+    "window.domAutomationController.send("
+    "document.getElementById('%s').value);";
+const char kSetTextBoxValueJS[] =
+    "window.domAutomationController.send("
+    "document.getElementById('%s').value = '%s');";
+const char kStartTestJS[] =
+    "window.domAutomationController.send(startTest(%d));";
 
 // Maximum lenght of the result array in KeyEventTestData structure.
 const size_t kMaxResultLength = 10;
 
 // A structure holding test data of a keyboard event.
 // Each keyboard event may generate multiple result strings representing
 // the result of keydown, keypress, keyup and textInput events.
 // For keydown, keypress and keyup events, the format of the result string is:
 // <type> <keyCode> <charCode> <ctrlKey> <shiftKey> <altKey> <commandKey>
 // where <type> may be 'D' (keydown), 'P' (keypress) or 'U' (keyup).
@@ skipping 11 matching lines @@
 
   bool suppress_keydown;
   bool suppress_keypress;
   bool suppress_keyup;
   bool suppress_textinput;
 
   int result_length;
   const char* const result[kMaxResultLength];
 };
 
-const wchar_t* GetBoolString(bool value) {
-  return value ? L"true" : L"false";
+const char* GetBoolString(bool value) {
+  return value ? "true" : "false";
 }
 
 // A class to help wait for the finish of a key event test.
 class TestFinishObserver : public content::NotificationObserver {
  public:
   explicit TestFinishObserver(RenderViewHost* render_view_host)
       : finished_(false), waiting_(false) {
     registrar_.Add(this, content::NOTIFICATION_DOM_OPERATION_RESPONSE,
                    content::Source<RenderViewHost>(render_view_host));
   }
@@ skipping 39 matching lines @@
     return ui_test_utils::IsViewFocused(browser(), vid);
   }
 
   void ClickOnView(ViewID vid) {
     ui_test_utils::ClickOnView(browser(), vid);
   }
 
   // Set the suppress flag of an event specified by |type|. If |suppress| is
   // true then the web page will suppress all events with |type|. Following
   // event types are supported: keydown, keypress, keyup and textInput.
-  void SuppressEventByType(int tab_index, const wchar_t* type, bool suppress) {
+  void SuppressEventByType(int tab_index, const char* type, bool suppress) {
     ASSERT_LT(tab_index, browser()->tab_count());
     bool actual;
     ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(
         browser()->GetWebContentsAt(tab_index)->GetRenderViewHost(),
         L"",
-        base::StringPrintf(kSuppressEventJS, type, GetBoolString(!suppress)),
+        ASCIIToWide(base::StringPrintf(kSuppressEventJS, type,
+                                       GetBoolString(!suppress))),
         &actual));
     ASSERT_EQ(!suppress, actual);
   }
 
   void SuppressEvents(int tab_index, bool keydown, bool keypress,
                       bool keyup, bool textinput) {
     ASSERT_NO_FATAL_FAILURE(
-        SuppressEventByType(tab_index, L"keydown", keydown));
+        SuppressEventByType(tab_index, "keydown", keydown));
     ASSERT_NO_FATAL_FAILURE(
-        SuppressEventByType(tab_index, L"keypress", keypress));
+        SuppressEventByType(tab_index, "keypress", keypress));
     ASSERT_NO_FATAL_FAILURE(
-        SuppressEventByType(tab_index, L"keyup", keyup));
+        SuppressEventByType(tab_index, "keyup", keyup));
     ASSERT_NO_FATAL_FAILURE(
-        SuppressEventByType(tab_index, L"textInput", textinput));
+        SuppressEventByType(tab_index, "textInput", textinput));
   }
 
   void SuppressAllEvents(int tab_index, bool suppress) {
     SuppressEvents(tab_index, suppress, suppress, suppress, suppress);
   }
 
   void GetResultLength(int tab_index, int* length) {
     ASSERT_LT(tab_index, browser()->tab_count());
     ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractInt(
         browser()->GetWebContentsAt(tab_index)->GetRenderViewHost(),
         L"", kGetResultLengthJS, length));
   }
 
   void CheckResult(int tab_index, int length, const char* const result[]) {
     ASSERT_LT(tab_index, browser()->tab_count());
     int actual_length;
     ASSERT_NO_FATAL_FAILURE(GetResultLength(tab_index, &actual_length));
     ASSERT_GE(actual_length, length);
     for (int i = 0; i < actual_length; ++i) {
       std::string actual;
       ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString(
           browser()->GetWebContentsAt(tab_index)->GetRenderViewHost(),
-          L"", base::StringPrintf(kGetResultJS, i), &actual));
+          L"", ASCIIToWide(base::StringPrintf(kGetResultJS, i)), &actual));
 
       // If more events were received than expected, then the additional events
       // must be keyup events.
       if (i < length)
         ASSERT_STREQ(result[i], actual.c_str());
       else
         ASSERT_EQ('U', actual[0]);
     }
   }
 
   void CheckFocusedElement(int tab_index, const wchar_t* focused) {
     ASSERT_LT(tab_index, browser()->tab_count());
     std::string actual;
     ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString(
         browser()->GetWebContentsAt(tab_index)->GetRenderViewHost(),
         L"", kGetFocusedElementJS, &actual));
     ASSERT_EQ(WideToUTF8(focused), actual);
   }
 
-  void SetFocusedElement(int tab_index, const wchar_t* focused) {
+  void SetFocusedElement(int tab_index, const char* focused) {
     ASSERT_LT(tab_index, browser()->tab_count());
     bool actual;
     ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(
         browser()->GetWebContentsAt(tab_index)->GetRenderViewHost(),
         L"",
-        base::StringPrintf(kSetFocusedElementJS, focused),
+        ASCIIToWide(base::StringPrintf(kSetFocusedElementJS, focused)),
         &actual));
     ASSERT_TRUE(actual);
   }
 
-  void CheckTextBoxValue(int tab_index, const wchar_t* id,
+  void CheckTextBoxValue(int tab_index, const char* id,
                          const wchar_t* value) {
     ASSERT_LT(tab_index, browser()->tab_count());
     std::string actual;
     ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString(
         browser()->GetWebContentsAt(tab_index)->GetRenderViewHost(),
         L"",
-        base::StringPrintf(kGetTextBoxValueJS, id),
+        ASCIIToWide(base::StringPrintf(kGetTextBoxValueJS, id)),
         &actual));
     ASSERT_EQ(WideToUTF8(value), actual);
   }
 
-  void SetTextBoxValue(int tab_index, const wchar_t* id,
-                       const wchar_t* value) {
+  void SetTextBoxValue(int tab_index, const char* id,
+                       const char* value) {
     ASSERT_LT(tab_index, browser()->tab_count());
     std::string actual;
     ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString(
         browser()->GetWebContentsAt(tab_index)->GetRenderViewHost(),
         L"",
-        base::StringPrintf(kSetTextBoxValueJS, id, value),
+        ASCIIToWide(base::StringPrintf(kSetTextBoxValueJS, id, value)),
         &actual));
-    ASSERT_EQ(WideToUTF8(value), actual);
+    ASSERT_STREQ(value, actual.c_str());
   }
 
   void StartTest(int tab_index, int result_length) {
     ASSERT_LT(tab_index, browser()->tab_count());
     bool actual;
     ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(
         browser()->GetWebContentsAt(tab_index)->GetRenderViewHost(),
-        L"", base::StringPrintf(kStartTestJS, result_length), &actual));
+        L"", ASCIIToWide(base::StringPrintf(kStartTestJS, result_length)),
+        &actual));
     ASSERT_TRUE(actual);
   }
 
   void TestKeyEvent(int tab_index, const KeyEventTestData& test) {
     ASSERT_LT(tab_index, browser()->tab_count());
     ASSERT_EQ(tab_index, browser()->active_index());
 
     // Inform our testing web page that we are about to start testing a key
     // event.
     ASSERT_NO_FATAL_FAILURE(StartTest(tab_index, test.result_length));
@@ skipping 111 matching lines @@
   ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER));
 
   int tab_index = browser()->active_index();
   for (size_t i = 0; i < arraysize(kTestNoInput); ++i) {
     EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestNoInput[i]))
         << "kTestNoInput[" << i << "] failed:\n"
         << GetTestDataDescription(kTestNoInput[i]);
   }
 
   // Input in normal text box.
-  ASSERT_NO_FATAL_FAILURE(SetFocusedElement(tab_index, L"A"));
+  ASSERT_NO_FATAL_FAILURE(SetFocusedElement(tab_index, "A"));
   for (size_t i = 0; i < arraysize(kTestWithInput); ++i) {
     EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestWithInput[i]))
         << "kTestWithInput[" << i << "] in text box failed:\n"
         << GetTestDataDescription(kTestWithInput[i]);
   }
-  EXPECT_NO_FATAL_FAILURE(CheckTextBoxValue(tab_index, L"A", L"aA"));
+  EXPECT_NO_FATAL_FAILURE(CheckTextBoxValue(tab_index, "A", L"aA"));
 
   // Input in password box.
-  ASSERT_NO_FATAL_FAILURE(SetFocusedElement(tab_index, L"B"));
+  ASSERT_NO_FATAL_FAILURE(SetFocusedElement(tab_index, "B"));
   for (size_t i = 0; i < arraysize(kTestWithInput); ++i) {
     EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestWithInput[i]))
         << "kTestWithInput[" << i << "] in password box failed:\n"
         << GetTestDataDescription(kTestWithInput[i]);
   }
-  EXPECT_NO_FATAL_FAILURE(CheckTextBoxValue(tab_index, L"B", L"aA"));
+  EXPECT_NO_FATAL_FAILURE(CheckTextBoxValue(tab_index, "B", L"aA"));
 }
 
 #if defined(OS_WIN) || defined(OS_LINUX)
 
 #if defined(OS_LINUX)
 // http://crbug.com/129235
 #define MAYBE_CtrlKeyEvents FAILS_CtrlKeyEvents
 #else
 #define MAYBE_CtrlKeyEvents CtrlKeyEvents
 #endif
@@ skipping 212 matching lines @@
   ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER));
 
   int tab_index = browser()->active_index();
   // Make sure no element is focused.
   EXPECT_NO_FATAL_FAILURE(CheckFocusedElement(tab_index, L""));
   // Alt+A should focus the element with accesskey = "A".
   EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestAccessA));
   EXPECT_NO_FATAL_FAILURE(CheckFocusedElement(tab_index, L"A"));
 
   // Blur the focused element.
-  EXPECT_NO_FATAL_FAILURE(SetFocusedElement(tab_index, L""));
+  EXPECT_NO_FATAL_FAILURE(SetFocusedElement(tab_index, ""));
   // Make sure no element is focused.
   EXPECT_NO_FATAL_FAILURE(CheckFocusedElement(tab_index, L""));
 
 #if !defined(OS_MACOSX)
   // Alt+D should move the focus to the location entry.
   EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestAccessD));
 
   // TODO(isherman): This is an experimental change to help diagnose
   // http://crbug.com/55713
   ui_test_utils::RunAllPendingInMessageLoop();
@@ skipping 15 matching lines @@
 
   // If the keydown event is suppressed, then Alt+D should be handled as an
   // accesskey rather than an accelerator key. Activation of an accesskey is not
   // a part of the default action of the key event, so it should not be
   // suppressed at all.
   EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestAccessDSuppress));
   ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER));
   EXPECT_NO_FATAL_FAILURE(CheckFocusedElement(tab_index, L"D"));
 
   // Blur the focused element.
-  EXPECT_NO_FATAL_FAILURE(SetFocusedElement(tab_index, L""));
+  EXPECT_NO_FATAL_FAILURE(SetFocusedElement(tab_index, ""));
   // Make sure no element is focused.
   EXPECT_NO_FATAL_FAILURE(CheckFocusedElement(tab_index, L""));
 #if !defined(USE_ASH)
   // On Ash, alt-1..9 are assigned as window selection global accelerators, so
   // they can not be used as accesskeys.
   EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestAccess1));
 #if defined(TOOLKIT_GTK)
   // On GTK, alt-0..9 are assigned as tab selection accelerators, so they can
   // not be used as accesskeys.
   EXPECT_NO_FATAL_FAILURE(CheckFocusedElement(tab_index, L""));
@@ skipping 110 matching lines @@
   ASSERT_TRUE(test_server()->Start());
 
   ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
   GURL url = test_server()->GetURL(kTestingPage);
   ui_test_utils::NavigateToURL(browser(), url);
 
   ASSERT_NO_FATAL_FAILURE(ClickOnView(VIEW_ID_TAB_CONTAINER));
   ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER));
 
   int tab_index = browser()->active_index();
-  ASSERT_NO_FATAL_FAILURE(SetFocusedElement(tab_index, L"A"));
-  ASSERT_NO_FATAL_FAILURE(SetTextBoxValue(tab_index, L"A", L"Hello"));
+  ASSERT_NO_FATAL_FAILURE(SetFocusedElement(tab_index, "A"));
+  ASSERT_NO_FATAL_FAILURE(SetTextBoxValue(tab_index, "A", "Hello"));
   // Move the caret to the beginning of the line.
   EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestCtrlA));
   // Forward one character
   EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestCtrlF));
   // Delete to the end of the line.
   EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestCtrlK));
-  EXPECT_NO_FATAL_FAILURE(CheckTextBoxValue(tab_index, L"A", L"H"));
+  EXPECT_NO_FATAL_FAILURE(CheckTextBoxValue(tab_index, "A", L"H"));
 }
 #endif
 
 IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, PageUpDownKeys) {
   static const KeyEventTestData kTestPageUp = {
     ui::VKEY_PRIOR, false, false, false, false,
     false, false, false, false, 2,
     { "D 33 0 false false false false",
       "U 33 0 false false false false" }
   };
 
   static const KeyEventTestData kTestPageDown = {
     ui::VKEY_NEXT, false, false, false, false,
     false, false, false, false, 2,
     { "D 34 0 false false false false",
       "U 34 0 false false false false" }
   };
 
   ASSERT_TRUE(test_server()->Start());
 
   ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
   GURL url = test_server()->GetURL(kTestingPage);
   ui_test_utils::NavigateToURL(browser(), url);
 
   ASSERT_NO_FATAL_FAILURE(ClickOnView(VIEW_ID_TAB_CONTAINER));
   ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER));
 
   int tab_index = browser()->active_index();
-  ASSERT_NO_FATAL_FAILURE(SetFocusedElement(tab_index, L"A"));
+  ASSERT_NO_FATAL_FAILURE(SetFocusedElement(tab_index, "A"));
   EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestPageUp));
   EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestPageDown));
-  EXPECT_NO_FATAL_FAILURE(CheckTextBoxValue(tab_index, L"A", L""));
+  EXPECT_NO_FATAL_FAILURE(CheckTextBoxValue(tab_index, "A", L""));
 }
 
 #if defined(OS_WIN)
 // AltKey is enabled only on Windows. See crbug.com/114537.
 IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, FocusMenuBarByAltKey) {
   static const KeyEventTestData kTestAltKey = {
     ui::VKEY_MENU, false, false, false, false,
     false, false, false, false, 2,
     { "D 18 0 false false true false",
       "U 18 0 false false true false" }
@@ skipping 36 matching lines @@
   EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestAltKeySuppress));
   ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER));
 
   // Ctrl+Alt should have no effect.
   EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestCtrlAltKey));
   ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER));
 }
 #endif
 
 }  // namespace