Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1044843002: Set use_canvas_skia to 0 when building iOS (Closed)

Created:
5 years, 8 months ago by sdefresne
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@namespace
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set use_canvas_skia to 0 when building iOS iOS like Android does not compile render_text.cc used by canvas_skia.cc so change the value of use_canvas_skia to 0 on that platform to prevent invisible dependency (currently the linker is removing the methods that do depends on render_text.cc since they are not used). BUG=None Committed: https://crrev.com/48c11af6c797badfc9e8e9e2e48113b2b04ed4b0 Cr-Commit-Position: refs/heads/master@{#323029}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sdefresne
Please take a look.
5 years, 8 months ago (2015-03-30 09:46:25 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-03-31 10:24:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1044843002/1
5 years, 8 months ago (2015-03-31 12:29:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-31 13:51:57 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 13:52:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48c11af6c797badfc9e8e9e2e48113b2b04ed4b0
Cr-Commit-Position: refs/heads/master@{#323029}

Powered by Google App Engine
This is Rietveld 408576698