pylib/gyp/generator/ninja_test.py - Issue 10447063: Fix make and ninja backends to sensibly handle duplicate target names in different directories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/generator/ninja_test.py

Issue 10447063: Fix make and ninja backends to sensibly handle duplicate target names in different directories (Closed) Base URL: http://git.chromium.org/external/gyp.git@master

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pylib/gyp/generator/ninja_test.py

===================================================================

--- pylib/gyp/generator/ninja_test.py (revision 1414)

+++ pylib/gyp/generator/ninja_test.py (working copy)

@@ -16,7 +16,7 @@

class TestPrefixesAndSuffixes(unittest.TestCase):

if sys.platform in ('win32', 'cygwin'):

def test_BinaryNamesWindows(self):

- writer = ninja.NinjaWriter('wee', '.', '.', 'ninja.build', 'win')

+ writer = ninja.NinjaWriter('foo', 'wee', '.', '.', 'ninja.build', 'win')

spec = { 'target_name': 'wee' }

self.assertTrue(writer.ComputeOutputFileName(spec, 'executable').

endswith('.exe'))

@@ -27,7 +27,7 @@

if sys.platform == 'linux2':

def test_BinaryNamesLinux(self):

- writer = ninja.NinjaWriter('wee', '.', '.', 'ninja.build', 'linux')

+ writer = ninja.NinjaWriter('foo', 'wee', '.', '.', 'ninja.build', 'linux')

spec = { 'target_name': 'wee' }

self.assertTrue('.' not in writer.ComputeOutputFileName(spec,

'executable'))

« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | test/intermediate_dir/gyptest-intermediate-dir.py » ('j') | no next file with comments »