Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issue 1044623003: Subzero: Fix dependency checking to avoid unnecessary rebuilds. (Closed)

Created:
5 years, 8 months ago by Jim Stichnoth
Modified:
5 years, 8 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix dependency checking to avoid unnecessary rebuilds. When trying to do bisection debugging, the pnacl-llc translation was happening every time even if the pexe didn't change. This is because it was checking for a binary called 'llc' in the current directory, instead of an absolute path the pnacl-llc. (This check is done so that updating pnacl-llc triggers a rebuild of the bisection binary, similar to the check for an update of pnacl-sz.) BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=8c7b0a2ce1e91d170d0f225e6e911cd20956d4e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pydir/szbuild.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
5 years, 8 months ago (2015-03-29 00:15:29 UTC) #2
jvoung (off chromium)
lgtm
5 years, 8 months ago (2015-03-29 19:03:58 UTC) #3
Jim Stichnoth
5 years, 8 months ago (2015-03-29 22:20:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8c7b0a2ce1e91d170d0f225e6e911cd20956d4e9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698