DescriptionAdd missing dumpfile.cc to leveldatabase target in GN build.
This was found by looking at the output of gyp_flag_compare step in
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/24157/steps/gyp_flag_compare/logs/stdio
Tested on Linux with the following command lines:
$ gn gen out-gn
$ ninja -C out-gn leveldatabase
$ touch third_party/leveldatabase/src/db/dumpfile.cc
$ ninja -C out-gn leveldatabase
BUG=461019
TEST=see above
R=cmumford@chromium.org
TBR=brettw@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Committed: https://crrev.com/8a33c992e0a969f8ec7584da579980dba660e376
Cr-Commit-Position: refs/heads/master@{#322962}
Patch Set 1 #
Total comments: 2
Patch Set 2 : include dumpfile.h #Patch Set 3 : fix vim search and replace mess in TODO comment #Messages
Total messages: 9 (1 generated)
|