Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1044613002: Add missing dumpfile.cc to leveldatabase target in GN build. (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
cmumford
CC:
brettw, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing dumpfile.cc to leveldatabase target in GN build. This was found by looking at the output of gyp_flag_compare step in http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/24157/steps/gyp_flag_compare/logs/stdio Tested on Linux with the following command lines: $ gn gen out-gn $ ninja -C out-gn leveldatabase $ touch third_party/leveldatabase/src/db/dumpfile.cc $ ninja -C out-gn leveldatabase BUG=461019 TEST=see above R=cmumford@chromium.org TBR=brettw@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/8a33c992e0a969f8ec7584da579980dba660e376 Cr-Commit-Position: refs/heads/master@{#322962}

Patch Set 1 #

Total comments: 2

Patch Set 2 : include dumpfile.h #

Patch Set 3 : fix vim search and replace mess in TODO comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/secondary/third_party/leveldatabase/BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
tfarina
PTAL!
5 years, 9 months ago (2015-03-28 14:09:19 UTC) #1
cmumford
https://codereview.chromium.org/1044613002/diff/1/build/secondary/third_party/leveldatabase/BUILD.gn File build/secondary/third_party/leveldatabase/BUILD.gn (right): https://codereview.chromium.org/1044613002/diff/1/build/secondary/third_party/leveldatabase/BUILD.gn#newcode37 build/secondary/third_party/leveldatabase/BUILD.gn:37: "src/db/dumpfile.cc", Do we need src/include/leveldb/dumpfile.h too?
5 years, 8 months ago (2015-03-30 16:47:25 UTC) #2
tfarina
PTAL https://codereview.chromium.org/1044613002/diff/1/build/secondary/third_party/leveldatabase/BUILD.gn File build/secondary/third_party/leveldatabase/BUILD.gn (right): https://codereview.chromium.org/1044613002/diff/1/build/secondary/third_party/leveldatabase/BUILD.gn#newcode37 build/secondary/third_party/leveldatabase/BUILD.gn:37: "src/db/dumpfile.cc", On 2015/03/30 16:47:25, cmumford wrote: > Do ...
5 years, 8 months ago (2015-03-30 19:16:24 UTC) #3
cmumford
lgtm
5 years, 8 months ago (2015-03-30 19:18:04 UTC) #4
tfarina
TBRing Brett for this.
5 years, 8 months ago (2015-03-30 23:51:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1044613002/40001
5 years, 8 months ago (2015-03-30 23:52:34 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-03-31 02:39:27 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 02:40:10 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8a33c992e0a969f8ec7584da579980dba660e376
Cr-Commit-Position: refs/heads/master@{#322962}

Powered by Google App Engine
This is Rietveld 408576698