Integration test for exp Chrome-Proxy request option

Integration test for exp Chrome-Proxy request option

Test the experiment Chrome-Proxy directive by verifying that
a specific test URL only triggers a bypass when the command
line flag "--data-reduction-proxy-experiment=test" is set.

BUG=452292
Committed: https://crrev.com/29b6de07084e74a3e1236872bf76ff14985797ad
Cr-Commit-Position: refs/heads/master@{#324270}

[megjablon, 2015-04-02 20:49:19]

Patchset #1 (id:1) has been deleted

[megjablon, 2015-04-02 20:49:30]

Patchset #1 (id:20001) has been deleted

[megjablon, 2015-04-02 20:49:59]

megjablon@chromium.org changed reviewers:
+ sclittle@chromium.org

[sclittle, 2015-04-03 01:34:48]

https://codereview.chromium.org/1044573002/diff/40001/tools/chrome_proxy/inte...
File tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py (right):

https://codereview.chromium.org/1044573002/diff/40001/tools/chrome_proxy/inte...
tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py:128: tag =
'experiment'
"experiment" seems a bit ambiguous; maybe "experiment_target" or "exp_directive"
or something along those lines? Same with the classmethod Name below, and
measurements.ChromeProxyExperiment.

https://codereview.chromium.org/1044573002/diff/40001/tools/chrome_proxy/inte...
File tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py (right):

https://codereview.chromium.org/1044573002/diff/40001/tools/chrome_proxy/inte...
tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py:316: This test
verifies that experiment "test" in the Chrome-Proxy request header
Maybe reword 'experiment "test"' to '"exp=test"' here? Since you're describing
the format of the Chrome-Proxy request header here.

https://codereview.chromium.org/1044573002/diff/40001/tools/chrome_proxy/inte...
File tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/experiment.py
(right):

https://codereview.chromium.org/1044573002/diff/40001/tools/chrome_proxy/inte...
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/experiment.py:9:
class ExperimentPage(page_module.Page):
Again, "Experiment" seems ambigous; maybe "ExperimentDirective" or
"ExpDirective" or something? Just so it's clear that this is the "exp=<?>" in
the Chrome-Proxy header, and not some other kind of experiment.

https://codereview.chromium.org/1044573002/diff/40001/tools/chrome_proxy/inte...
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/experiment.py:24:
archive_data_file='../data/chrome_proxy_bypass.json')
Remove this archive_data_file variable; these don't apply to the chrome_proxy
tests since we run against live sites instead of using web page replay archives.

[megjablon, 2015-04-07 21:18:40]

https://codereview.chromium.org/1044573002/diff/40001/tools/chrome_proxy/inte...
File tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py (right):

https://codereview.chromium.org/1044573002/diff/40001/tools/chrome_proxy/inte...
tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py:316: This test
verifies that experiment "test" in the Chrome-Proxy request header
On 2015/04/03 01:34:48, sclittle wrote:
> Maybe reword 'experiment "test"' to '"exp=test"' here? Since you're describing
> the format of the Chrome-Proxy request header here.

Done.

https://codereview.chromium.org/1044573002/diff/40001/tools/chrome_proxy/inte...
File tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/experiment.py
(right):

https://codereview.chromium.org/1044573002/diff/40001/tools/chrome_proxy/inte...
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/experiment.py:9:
class ExperimentPage(page_module.Page):
On 2015/04/03 01:34:48, sclittle wrote:
> Again, "Experiment" seems ambigous; maybe "ExperimentDirective" or
> "ExpDirective" or something? Just so it's clear that this is the "exp=<?>" in
> the Chrome-Proxy header, and not some other kind of experiment.

Done.

https://codereview.chromium.org/1044573002/diff/40001/tools/chrome_proxy/inte...
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/experiment.py:24:
archive_data_file='../data/chrome_proxy_bypass.json')
On 2015/04/03 01:34:48, sclittle wrote:
> Remove this archive_data_file variable; these don't apply to the chrome_proxy
> tests since we run against live sites instead of using web page replay
archives.

Done.

[sclittle, 2015-04-07 21:34:14]

LGTM with a couple style nits

https://codereview.chromium.org/1044573002/diff/60001/tools/chrome_proxy/inte...
File tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py (right):

https://codereview.chromium.org/1044573002/diff/60001/tools/chrome_proxy/inte...
tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py:317: causes a
bypass on the experiment test page."""
nit: put the end """ on the next line.

see https://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Comments

https://codereview.chromium.org/1044573002/diff/60001/tools/chrome_proxy/inte...
File tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/exp_directive.py
(right):

https://codereview.chromium.org/1044573002/diff/60001/tools/chrome_proxy/inte...
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/exp_directive.py:11:
A test page for the experiment Chrome-Proxy directive tests.
nit: Move this line up, and remove the second line. e.g.:

"""A test page for the experiment Chrome-Proxy directive tests."""

[megjablon, 2015-04-08 18:20:58]

The CQ bit was checked by megjablon@chromium.org

[megjablon, 2015-04-08 18:20:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
sclittle@chromium.org
Link to the patchset: https://codereview.chromium.org/1044573002/#ps80001
(title: "Nits")

[commit-bot: I haz the power, 2015-04-08 18:22:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1044573002/80001

[commit-bot: I haz the power, 2015-04-08 19:29:57]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-04-08 19:30:54]

Patchset 3 (id:??) landed as
https://crrev.com/29b6de07084e74a3e1236872bf76ff14985797ad
Cr-Commit-Position: refs/heads/master@{#324270}