Issue 1044493002: Remove duplicate definition of Protocol Handler support URL

Issue 1044493002: Remove duplicate definition of Protocol Handler support URL (Closed)

Created:
5 years, 9 months ago by tomc

Modified:
5 years, 9 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove duplicate definition of Protocol Handler support URL A URL constant pointing to https://support.google.com/chrome/answer/1382847 existed in both handler_options_handler.cc and url_constants.cc. This removes the definition in handler_options_handler.cc. BUG=471318 Committed: https://crrev.com/d5620b8ff8e4d3e7ba75d1c798072f7eb4f123ce Cr-Commit-Position: refs/heads/master@{#322659}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -8 lines)			Patch
	M	chrome/browser/ui/webui/options/handler_options_handler.cc	View		2 chunks	+2 lines, -8 lines	0 comments	Download

Total messages: 7 (2 generated)

tomc

Hey James, Here is a duplicate CL of https://codereview.chromium.org/1033333002/ just so we can get this ...

5 years, 9 months ago (2015-03-27 21:23:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1044493002/1

5 years, 9 months ago (2015-03-27 21:37:52 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-27 22:23:12 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d5620b8ff8e4d3e7ba75d1c798072f7eb4f123ce
Cr-Commit-Position: refs/heads/master@{#322659}