Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 104443002: Simplify VTTParser::collectTimeStamp (Closed)

Created:
7 years ago by fs
Modified:
7 years ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Simplify VTTParser::collectTimeStamp Drop the various "is next character and ASCII digit" test that precede calls to collectDigitsToInt. The latter will perform both the "out of input" and "is ASCII digit" checks via collectDigits. BUG=305317 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M Source/core/html/track/vtt/VTTParser.cpp View 3 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fs
7 years ago (2013-12-04 13:01:22 UTC) #1
Mike West
On 2013/12/04 13:01:22, fs wrote: LGTM if you note in the description that 'collectDigits' does ...
7 years ago (2013-12-04 13:04:54 UTC) #2
fs
Description updated to mention collectDigits.
7 years ago (2013-12-04 13:12:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/104443002/1
7 years ago (2013-12-04 13:13:01 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-04 14:43:37 UTC) #5
Message was sent while issue was closed.
Change committed as 163174

Powered by Google App Engine
This is Rietveld 408576698