MD5: Use C-cast style in MD5Update() function.

MD5: Use C++ style cast in the API.

The entire code base prefers c++ style casting, but there is
the only occurrence of C++ cast (a static_cast), the rest
of this file is using C-cast style.

So we go the other way round and converted everything from
C to C++ way of casting.

BUG=None
TEST=base_unittests --gtest_filter=MD5*
R=thestig@chromium.org

Committed: https://crrev.com/2c4c844dbbcd98850769ddaf4429eca99c990839
Cr-Commit-Position: refs/heads/master@{#326795}

[tfarina, 2015-04-23 01:25:05]

Very minor, but still consistent.

[Lei Zhang, 2015-04-23 02:14:44]

The entire code base prefers c++ style casting, so we should go the other way.

[tfarina, 2015-04-23 02:36:37]

Done. Please, see if I got everything right. I'm not sure I did. Check it
carefully.

[Lei Zhang, 2015-04-23 03:06:01]

lgtm

https://codereview.chromium.org/1044423007/diff/20001/base/md5.cc
File base/md5.cc (right):

https://codereview.chromium.org/1044423007/diff/20001/base/md5.cc#newcode42
base/md5.cc:42: t = static_cast<uint32_t>(static_cast<unsigned>(buf[3]) << 8 |
buf[2])
This is a bit hairy. How about indenting it like this?

uint32_t temp = static_cast<uint32_t>(
    static_cast<unsigned>(buf[3]) << 8 |
    buf[2]) << 16 |
    (static_cast<unsigned>(buf[1]) << 8 | buf[0]));

|t| is also not a great variable name...

[Lei Zhang, 2015-04-23 03:16:33]

Oh, and update the CL description.

[tfarina, 2015-04-23 13:09:43]

CL description updated too.

https://codereview.chromium.org/1044423007/diff/20001/base/md5.cc
File base/md5.cc (right):

https://codereview.chromium.org/1044423007/diff/20001/base/md5.cc#newcode42
base/md5.cc:42: t = static_cast<uint32_t>(static_cast<unsigned>(buf[3]) << 8 |
buf[2])
On 2015/04/23 03:06:01, Lei Zhang wrote:
> This is a bit hairy. How about indenting it like this?
> 
> uint32_t temp = static_cast<uint32_t>(
>     static_cast<unsigned>(buf[3]) << 8 |
>     buf[2]) << 16 |
>     (static_cast<unsigned>(buf[1]) << 8 | buf[0]));
> 
> |t| is also not a great variable name...

Done.

[tfarina, 2015-04-24 13:55:00]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-04-24 13:55:01]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1044423007/#ps60001
(title: "fix indentation")

[commit-bot: I haz the power, 2015-04-24 13:55:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1044423007/60001

[commit-bot: I haz the power, 2015-04-24 14:56:39]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-24 14:57:29]

Patchset 4 (id:??) landed as
https://crrev.com/2c4c844dbbcd98850769ddaf4429eca99c990839
Cr-Commit-Position: refs/heads/master@{#326795}