Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1044423005: Expose CC.host_wrapper and CXX.host_wrapper. (Closed)

Created:
5 years, 8 months ago by cwgreene
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose CC.host_wrapper and CXX.host_wrapper. Currently, the gyp variables CC_wrapper and CXX_wrapper can be set in the chromium.gyp_env file. However, the host compiler wrapper variable cannot. By exposing this variable, embedders can more easily use tools like ccache or icecream when developing for android. BUG=471340 Committed: https://crrev.com/73e65d4adbbc1cc83f7e59b2dfe60107c2dd186e Cr-Commit-Position: refs/heads/master@{#323557}

Patch Set 1 #

Patch Set 2 : Adding reviewer #

Patch Set 3 : Change virtual to override in devtools generator code. #

Patch Set 4 : Make Python Code Generate Chromium Styled Code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
cwgreene
On 2015/04/02 17:26:39, cwgreene wrote: > mailto:cwgreene@amazon.com changed reviewers: > + mailto:dpranke@chromium.org PTAL. The patches ...
5 years, 8 months ago (2015-04-02 17:27:18 UTC) #2
Dirk Pranke
lgtm
5 years, 8 months ago (2015-04-02 17:41:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1044423005/20001
5 years, 8 months ago (2015-04-02 17:57:13 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-02 20:42:15 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:28:51 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/73e65d4adbbc1cc83f7e59b2dfe60107c2dd186e
Cr-Commit-Position: refs/heads/master@{#323557}

Powered by Google App Engine
This is Rietveld 408576698