Improve map insertions

snapshot/minidump/minidump_simple_string_dictionary_reader.cc

Index: snapshot/minidump/minidump_simple_string_dictionary_reader.cc
diff --git a/snapshot/minidump/minidump_simple_string_dictionary_reader.cc b/snapshot/minidump/minidump_simple_string_dictionary_reader.cc
index 085c1f60dec33fe385b4a7bff4913de7f8f891a7..0d8301c1b300c1e6ce94b21491802f495faa5149 100644
--- a/snapshot/minidump/minidump_simple_string_dictionary_reader.cc
+++ b/snapshot/minidump/minidump_simple_string_dictionary_reader.cc
@@ -72,12 +72,10 @@ bool ReadMinidumpSimpleStringDictionary(
       return false;
     }
 
-    if (local_dictionary.find(key) != local_dictionary.end()) {
-      LOG(WARNING) << "duplicate key " << key << ", discarding value " << value;
+    if (!local_dictionary.insert(std::make_pair(key, value)).second) {
+      LOG(ERROR) << "duplicate key " << key;

[scottmg, 2015/03/31 18:16:15]

log level change was intentional?

[Mark Mentovai, 2015/03/31 18:21:32]

scottmg wrote:
Yeah, this used to not cause the function to fail, but it changed along the way
(https://codereview.chromium.org/972383002/diff/60001/snapshot/minidump/minidu...).
The log message never got updated to match.

       return false;
     }
-
-    local_dictionary.insert(std::make_pair(key, value));
   }
 
   dictionary->swap(local_dictionary);