Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: snapshot/minidump/process_snapshot_minidump.cc

Issue 1044273002: Improve map insertions (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Crashpad Authors. All rights reserved. 1 // Copyright 2015 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 &minidump_links[0], 302 &minidump_links[0],
303 crashpad_module_count * sizeof(MinidumpModuleCrashpadInfoLink))) { 303 crashpad_module_count * sizeof(MinidumpModuleCrashpadInfoLink))) {
304 return false; 304 return false;
305 } 305 }
306 306
307 for (uint32_t crashpad_module_index = 0; 307 for (uint32_t crashpad_module_index = 0;
308 crashpad_module_index < crashpad_module_count; 308 crashpad_module_index < crashpad_module_count;
309 ++crashpad_module_index) { 309 ++crashpad_module_index) {
310 const MinidumpModuleCrashpadInfoLink& minidump_link = 310 const MinidumpModuleCrashpadInfoLink& minidump_link =
311 minidump_links[crashpad_module_index]; 311 minidump_links[crashpad_module_index];
312 if (module_crashpad_info_links->find( 312 if (!module_crashpad_info_links
313 minidump_link.minidump_module_list_index) != 313 ->insert(std::make_pair(minidump_link.minidump_module_list_index,
314 module_crashpad_info_links->end()) { 314 minidump_link.location)).second) {
315 LOG(WARNING) 315 LOG(WARNING)
316 << "duplicate module_crashpad_info_list minidump_module_list_index " 316 << "duplicate module_crashpad_info_list minidump_module_list_index "
317 << minidump_link.minidump_module_list_index; 317 << minidump_link.minidump_module_list_index;
318 return false; 318 return false;
319 } else {
320 module_crashpad_info_links->insert(std::make_pair(
321 minidump_link.minidump_module_list_index, minidump_link.location));
322 } 319 }
323 } 320 }
324 321
325 return true; 322 return true;
326 } 323 }
327 324
328 } // namespace crashpad 325 } // namespace crashpad
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698