MacViews: Remove BrowserWindowUtils dependency from accelerator_utils_cocoa

MacViews: Remove BrowserWindowUtils dependency from accelerator_utils_cocoa

MacViews browser wants to link with accelerator_utils_cocoa but not with
BrowserWindowUtils. To achieve this, move the code in +getCommandId
from BrowserWindowUtils to global_keyboard_shortcuts_mac.

Also simplified MenuWalker helper class into a function in anon namespace.

BUG=425229
Committed: https://crrev.com/2389f84559bde7ed9a91b25aed69a7e532b48864
Cr-Commit-Position: refs/heads/master@{#323140}

[Andre, 2015-03-31 17:44:32]

Patchset #1 (id:1) has been deleted

[Andre, 2015-03-31 18:33:22]

andresantoso@chromium.org changed reviewers:
+ rsesek@chromium.org

[Andre, 2015-03-31 18:33:22]

Robert, please review.

[Robert Sesek, 2015-03-31 22:51:36]

LGTM

https://codereview.chromium.org/1044233004/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_utils.mm (left):

https://codereview.chromium.org/1044233004/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_utils.mm:26: +
(NSMenuItem*)itemForKeyEquivalent:(NSEvent*)key
(Why was this ever a class?)

[Andre, 2015-03-31 23:21:57]

https://codereview.chromium.org/1044233004/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_utils.mm (left):

https://codereview.chromium.org/1044233004/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_utils.mm:26: +
(NSMenuItem*)itemForKeyEquivalent:(NSEvent*)key
On 2015/03/31 22:51:36, Robert Sesek wrote:
> (Why was this ever a class?)

It came from here: https://codereview.chromium.org/273032
No particular reason I think. It works almost equally well, I just didn't like
the unnecessary verbosity.

[Andre, 2015-03-31 23:22:32]

The CQ bit was checked by andresantoso@chromium.org

[commit-bot: I haz the power, 2015-03-31 23:23:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1044233004/20001

[commit-bot: I haz the power, 2015-03-31 23:26:49]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2015-03-31 23:27:29]

Patchset 1 (id:??) landed as
https://crrev.com/2389f84559bde7ed9a91b25aed69a7e532b48864
Cr-Commit-Position: refs/heads/master@{#323140}