Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp - Issue 1044203004: [Storage] Cache storage inspection on all the frames!

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

Issue 1044203004: [Storage] Cache storage inspection on all the frames! (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: More cleanup Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/serviceworkers/InspectorServiceWorkerCacheAgent.cpp ('K') | « Source/modules/serviceworkers/InspectorServiceWorkerCacheAgent.cpp ('k') | Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

diff --git a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

index 3af04a81b7690dda7fef14a5c822c0d19d849f5c..73b6df8cfc7a08dbd9dd980f108931fc56d63074 100644

--- a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

+++ b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

@@ -95,7 +95,7 @@ ServiceWorkerGlobalScope::ServiceWorkerGlobalScope(const KURL& url, const String

, m_hadErrorInTopLevelEventHandler(false)

, m_eventNestingLevel(0)

{

- workerInspectorController()->registerModuleAgent(InspectorServiceWorkerCacheAgent::create(this));

+ workerInspectorController()->registerModuleAgent(InspectorServiceWorkerCacheAgent::create());

jsbell 2015/04/03 03:21:08 Is this still necessary, or can the Cache Storage

pfeldman 2015/04/03 09:15:58 Good point, it should only be in WebDevToolsAgentI

}

ServiceWorkerGlobalScope::~ServiceWorkerGlobalScope()