Source/devtools/front_end/sdk/Target.js - Issue 1044203004: [Storage] Cache storage inspection on all the frames!

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/sdk/Target.js

Issue 1044203004: [Storage] Cache storage inspection on all the frames! (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/sdk/ServiceWorkerManager.js ('K') | « Source/devtools/front_end/sdk/ServiceWorkerManager.js ('k') | Source/devtools/front_end/sdk/WorkerManager.js » ('j') | Source/modules/serviceworkers/InspectorServiceWorkerCacheAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/sdk/Target.js

diff --git a/Source/devtools/front_end/sdk/Target.js b/Source/devtools/front_end/sdk/Target.js

index 1fa3501160c8709841ae8962681c63f78e5aec34..376a1912659d53749d2afeab1aa63640d5c89067 100644

--- a/Source/devtools/front_end/sdk/Target.js

+++ b/Source/devtools/front_end/sdk/Target.js

@@ -153,11 +153,6 @@ WebInspector.Target.prototype = {

/** @type {!WebInspector.AnimationModel} */

this.animationModel = new WebInspector.AnimationModel(this);

- if (this._parentTarget && this._parentTarget.isServiceWorker()) {

- /** @type {!WebInspector.ServiceWorkerCacheModel} */

- this.serviceWorkerCacheModel = new WebInspector.ServiceWorkerCacheModel(this);

- }

this.tracingManager = new WebInspector.TracingManager(this);

if (this.isPage() && (Runtime.experiments.isEnabled("serviceWorkersInPageFrontend") || Runtime.experiments.isEnabled("serviceWorkersInResources")))

@@ -252,8 +247,7 @@ WebInspector.Target.prototype = {

this.debuggerModel.dispose();

this.networkManager.dispose();

this.cpuProfilerModel.dispose();

- if (this.serviceWorkerCacheModel)

- this.serviceWorkerCacheModel.dispose();

+ WebInspector.ServiceWorkerCacheModel.fromTarget(this).dispose();

if (this.workerManager)

this.workerManager.dispose();