LayoutTests/http/tests/inspector/cache-storage/cache-data.html - Issue 1044203004: [Storage] Cache storage inspection on all the frames!

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/inspector/cache-storage/cache-data.html

Issue 1044203004: [Storage] Cache storage inspection on all the frames! (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/http/tests/inspector/cache-storage/cache-data-expected.txt » ('j') | LayoutTests/http/tests/inspector/cache-storage/cache-data-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../inspector-test.js"></script>

	4 <script src="cache-storage-test.js"></script>

	5 <script>

	6 function test()

	7 {

	8 var cacheStorageModel = WebInspector.ServiceWorkerCacheModel.fromTarget(WebI nspector.targetManager.mainTarget());

	9 cacheStorageModel.enable();

	10 var mainFrameId = InspectorTest.resourceTreeModel.mainFrame.id;

	11

	12 InspectorTest.addSniffer(WebInspector.ServiceWorkerCacheModel.prototype, "_u pdateCacheNames", main, false);

	13

	14 function errorAndExit(error)

	15 {

	16 console.error(error);
	pfeldman 2015/04/10 12:35:33 4 space indent. 4 space indent. dmurph 2015/04/13 18:23:03 Done. Show quoted text On 2015/04/10 at 12:35:33, pfeldman wrote: > 4 space indent. Done.
	17 InspectorTest.completeTest();

	18 }

	19

	20 function before()

	21 {

	22 return caches.keys().then(function(keys) {
	pfeldman 2015/04/10 12:35:33 These are the caches of the inspector front-end, n These are the caches of the inspector front-end, not the page under test. I assume this is important. dmurph 2015/04/13 18:23:03 Fixed. Show quoted text On 2015/04/10 at 12:35:33, pfeldman wrote: > These are the caches of the inspector front-end, not the page under test. I assume this is important. Fixed.
	23 return Promise.all(keys.map(function(key) {
	pfeldman 2015/04/10 12:35:33 4 space indent. 4 space indent. dmurph 2015/04/13 18:23:03 Done. Show quoted text On 2015/04/10 at 12:35:33, pfeldman wrote: > 4 space indent. Done.
	24 return caches.delete(key);

	25 }));

	26 });

	27 }

	28

	29 function main()

	30 {

	31 before()

	32 .then(InspectorTest.dumpCacheTree)

	33 .then(InspectorTest.createCache.bind(this, mainFrameId, "testCache1" ))

	34 .then(InspectorTest.createCache.bind(this, mainFrameId, "testCache2" ))

	35 .then(InspectorTest.dumpCacheTree)

	36 .then(InspectorTest.addCacheEntry.bind(this, mainFrameId, "testCache 1", "http://fake.request.com/1", "OK"))

	37 .then(InspectorTest.addCacheEntry.bind(this, mainFrameId, "testCache 1", "http://fake.request.com/2", "Not Found"))

	38 .then(InspectorTest.addCacheEntry.bind(this, mainFrameId, "testCache 2", "http://fake.request2.com/1", "OK"))

	39 .then(InspectorTest.addCacheEntry.bind(this, mainFrameId, "testCache 2", "http://fake.request2.com/2", "Not Found"))

	40 .then(InspectorTest.dumpCacheTree)

	41 .then(InspectorTest.completeTest)

	42 .catch(errorAndExit);

	43 }

	44 }

	45 </script>

	46 </head>

	47 <body onload="runTest()">

	48 <p>Tests that cache data is correctly populated in the Inspector.</p>

	49 </body>

	50 </html>

OLD	NEW