Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1044173002: [V8] Don't ignore sourceURL comment in inline scripts in .stack (Closed)

Created:
5 years, 8 months ago by kozy
Modified:
5 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[V8] Don't ignore sourceURL comment in inline scripts in .stack In DevTools we've already used sourceURL in inline scripts. This CL makes the behavior of the V8 in the same for Error.stack property and v8::StackTrace. BUG=v8:3920 LOG=Y R=yangguo@chromium.org Committed: https://crrev.com/9f6b1333a10ba27cfb59dedc705cd5917ca702cd Cr-Commit-Position: refs/heads/master@{#27554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M src/messages.js View 2 chunks +3 lines, -8 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
kozy
Yang, please take a look.
5 years, 8 months ago (2015-03-31 12:46:01 UTC) #1
Yang
On 2015/03/31 12:46:01, kozyatinskiy wrote: > Yang, please take a look. Lgtm.
5 years, 8 months ago (2015-03-31 18:31:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1044173002/1
5 years, 8 months ago (2015-03-31 19:34:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-31 19:36:05 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 19:36:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f6b1333a10ba27cfb59dedc705cd5917ca702cd
Cr-Commit-Position: refs/heads/master@{#27554}

Powered by Google App Engine
This is Rietveld 408576698