Oilpan: Centralize Partition allocators into Partitions.h (part 2)

Source/wtf/Partitions.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 29 matching lines @@
 public:
     static void initialize();
     static void shutdown();
     ALWAYS_INLINE static PartitionRootGeneric* getBufferPartition()
     {
         if (UNLIKELY(!s_initialized))
             initialize();
         return m_bufferAllocator.root();
     }
 
-    ALWAYS_INLINE static PartitionRoot* getObjectModelPartition() { return m_objectModelAllocator.root(); }
-    ALWAYS_INLINE static PartitionRoot* getRenderingPartition() { return m_renderingAllocator.root(); }
+    ALWAYS_INLINE static PartitionRootGeneric* getFastMallocPartition()
+    {
+        if (UNLIKELY(!s_initialized))
+            initialize();

[tkent, 2015/04/01 01:26:09]

Why is this necessary?  Is it possible to call getFastMallocPartition() before
WTF::initialize()?

[haraken, 2015/04/01 01:33:07]

Yes, it's possible. The fastmalloc allocator (and the buffer allocator (for
Strings etc)) can be called by DEFINE_STATIC_LOCAL etc.

[tkent, 2015/04/01 01:35:37]

I see.  Thanks.

Adding comments to getFastMallocPartition and getBufferPartition would be
helpful.

[Chris Evans, 2015/04/01 01:38:48]

Is that fixable I wonder? It'd be nice to remove that if statement from the hot
paths :) Or maybe it's not measurable.

+        return m_fastMallocAllocator.root();
+    }
+
+    ALWAYS_INLINE static PartitionRoot* getObjectModelPartition()
+    {
+        ASSERT(s_initialized);
+        return m_objectModelAllocator.root();
+    }
+    ALWAYS_INLINE static PartitionRoot* getRenderingPartition()
+    {
+        ASSERT(s_initialized);
+        return m_renderingAllocator.root();
+    }
 
     static size_t currentDOMMemoryUsage()
     {
+        ASSERT(s_initialized);
         return m_objectModelAllocator.root()->totalSizeOfCommittedPages;
     }
 
 private:
     static bool s_initialized;
+    static PartitionAllocatorGeneric m_fastMallocAllocator;
     static PartitionAllocatorGeneric m_bufferAllocator;
     static SizeSpecificPartitionAllocator<3328> m_objectModelAllocator;
     static SizeSpecificPartitionAllocator<1024> m_renderingAllocator;
 };
 
 } // namespace WTF
 
 #endif // Partitions_h