Source/core/dom/Document.cpp - Issue 1044133002: HTMLPreloadScanner should only use valid <base> urls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.cpp

Issue 1044133002: HTMLPreloadScanner should only use valid <base> urls (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: update tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Document.cpp

diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp

index 4bd356449867a7b8652b9dc66869cdd11ce155ea..1769b070541d4a0e41c744d0daa970b810b8edc5 100644

--- a/Source/core/dom/Document.cpp

+++ b/Source/core/dom/Document.cpp

@@ -4193,6 +4193,8 @@ KURL Document::completeURL(const String& url) const

KURL Document::completeURLWithOverride(const String& url, const KURL& baseURLOverride) const

{

+ ASSERT(baseURLOverride.isEmpty() || baseURLOverride.isValid());

// Always return a null URL when passed a null string.

// FIXME: Should we change the KURL constructor to have this behavior?

// See also [CSS]StyleSheet::completeURL(const String&)