LayoutTests/fast/parser/badurl-base-should-be-ignored.html - Issue 1044133002: HTMLPreloadScanner should only use valid <base> urls

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/parser/badurl-base-should-be-ignored.html

Issue 1044133002: HTMLPreloadScanner should only use valid <base> urls (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: update tests Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <script src="../../resources/js-test.js"></script>
	Yoav Weiss 2015/04/02 05:29:09 Can you add a DOCTYPE? Can you add a DOCTYPE? kouhei (in TOK) 2015/04/02 06:19:39 Done. Show quoted text On 2015/04/02 05:29:09, Yoav Weiss wrote: > Can you add a DOCTYPE? Done.
	2 <base href="gopher:???:"></base>

	3 <script>

	4 window.fail = false;

	5 </script>

	6 <!-- The resource should not be read, as the baseUrl is now set to empty from re ading invalid url -->

	7 <script src="resources/fail.js"></script>
	Yoav Weiss 2015/04/02 05:29:09 Did that fail before your change? AFAIU you're jus Did that fail before your change? AFAIU you're just testing if the JS was applied, not if the preloadScanner picked it up and downloaded it. kouhei (in TOK) 2015/04/02 06:19:39 No. Show quoted text On 2015/04/02 05:29:09, Yoav Weiss wrote: > Did that fail before your change? No. Show quoted text > AFAIU you're just testing if the JS was applied, not if the preloadScanner > picked it up and downloaded it. Yes. Currently we can't test the preloader reliably.
	8 <script>

	9 shouldBeFalse('window.fail')

	10 </script>

OLD	NEW