LayoutTests/fast/parser/badurl-head-preloader-crash.html - Issue 1044133002: HTMLPreloadScanner should only use valid <base> urls

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/parser/badurl-head-preloader-crash.html

Issue 1044133002: HTMLPreloadScanner should only use valid <base> urls (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <base href="gopher:��&#279%�:0"></base>

	2 <script src=":"></script>
	Yoav Weiss 2015/03/31 11:04:43 Can you add another test where we see that the inv Can you add another test where we see that the invalid base URL is not taken into account? kouhei (in TOK) 2015/03/31 11:15:38 Acknowledged. Show quoted text On 2015/03/31 11:04:43, Yoav Weiss wrote: > Can you add another test where we see that the invalid base URL is not taken > into account? Acknowledged. kouhei (in TOK) 2015/04/01 03:49:05 Done. Show quoted text On 2015/03/31 11:15:38, kouhei wrote: > On 2015/03/31 11:04:43, Yoav Weiss wrote: > > Can you add another test where we see that the invalid base URL is not taken > > into account? > > Acknowledged. Done.
	3 <script>

	4 if (window.testRunner) testRunner.dumpAsText();

	5 </script>

	6 <p>PASS: if scanning this document with preloader doesn't crash in debug builds< /p>

OLD	NEW