Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: ui/views/bubble/bubble_frame_view.cc

Issue 1044043004: Don't add an aura tooltip to bubble close buttons on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use define Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/bubble/bubble_frame_view.cc
diff --git a/ui/views/bubble/bubble_frame_view.cc b/ui/views/bubble/bubble_frame_view.cc
index dff1e993c38982f0e6869eebfe6b7b7a9b7b85c6..cd616ebb526f3b4c56d0fa3b374bf641f37e5fdb 100644
--- a/ui/views/bubble/bubble_frame_view.cc
+++ b/ui/views/bubble/bubble_frame_view.cc
@@ -105,7 +105,11 @@ LabelButton* BubbleFrameView::CreateCloseButton(ButtonListener* listener) {
*rb.GetImageNamed(IDR_CLOSE_DIALOG_P).ToImageSkia());
close->SetBorder(nullptr);
close->SetSize(close->GetPreferredSize());
+#if !defined(OS_WIN)
+ // Windows will automatically create a tooltip for the close button based on
+ // the HTCLOSE result from NonClientHitTest().
close->SetTooltipText(l10n_util::GetStringUTF16(IDS_APP_CLOSE));
+#endif
return close;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698