Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: src/code-stubs-hydrogen.cc

Issue 104403008: Pretenure mode was erroneously consulted in FastCloneShallowObjectStub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 442 matching lines...) Expand 10 before | Expand all | Expand 10 after
453 HValue* boilerplate_size = Add<HLoadNamedField>( 453 HValue* boilerplate_size = Add<HLoadNamedField>(
454 boilerplate_map, HObjectAccess::ForMapInstanceSize()); 454 boilerplate_map, HObjectAccess::ForMapInstanceSize());
455 HValue* size_in_words = Add<HConstant>(object_size >> kPointerSizeLog2); 455 HValue* size_in_words = Add<HConstant>(object_size >> kPointerSizeLog2);
456 checker.If<HCompareNumericAndBranch>(boilerplate_size, 456 checker.If<HCompareNumericAndBranch>(boilerplate_size,
457 size_in_words, Token::EQ); 457 size_in_words, Token::EQ);
458 checker.Then(); 458 checker.Then();
459 459
460 HValue* size_in_bytes = Add<HConstant>(size); 460 HValue* size_in_bytes = Add<HConstant>(size);
461 461
462 HInstruction* object = Add<HAllocate>(size_in_bytes, HType::JSObject(), 462 HInstruction* object = Add<HAllocate>(size_in_bytes, HType::JSObject(),
463 isolate()->heap()->GetPretenureMode(), JS_OBJECT_TYPE); 463 NOT_TENURED, JS_OBJECT_TYPE);
464 464
465 for (int i = 0; i < object_size; i += kPointerSize) { 465 for (int i = 0; i < object_size; i += kPointerSize) {
466 HObjectAccess access = HObjectAccess::ForJSObjectOffset(i); 466 HObjectAccess access = HObjectAccess::ForJSObjectOffset(i);
467 Add<HStoreNamedField>(object, access, 467 Add<HStoreNamedField>(object, access,
468 Add<HLoadNamedField>(boilerplate, access)); 468 Add<HLoadNamedField>(boilerplate, access));
469 } 469 }
470 470
471 ASSERT(FLAG_allocation_site_pretenuring || (size == object_size)); 471 ASSERT(FLAG_allocation_site_pretenuring || (size == object_size));
472 if (FLAG_allocation_site_pretenuring) { 472 if (FLAG_allocation_site_pretenuring) {
473 BuildCreateAllocationMemento( 473 BuildCreateAllocationMemento(
(...skipping 858 matching lines...) Expand 10 before | Expand all | Expand 10 after
1332 return BuildUncheckedDictionaryElementLoad(receiver, key); 1332 return BuildUncheckedDictionaryElementLoad(receiver, key);
1333 } 1333 }
1334 1334
1335 1335
1336 Handle<Code> KeyedLoadDictionaryElementStub::GenerateCode(Isolate* isolate) { 1336 Handle<Code> KeyedLoadDictionaryElementStub::GenerateCode(Isolate* isolate) {
1337 return DoGenerateCode(isolate, this); 1337 return DoGenerateCode(isolate, this);
1338 } 1338 }
1339 1339
1340 1340
1341 } } // namespace v8::internal 1341 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698