Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 104403004: update armv6 floating point defaults (Closed)

Created:
7 years ago by Mostyn Bramley-Moore
Modified:
7 years ago
Reviewers:
digit1
CC:
chromium-reviews
Visibility:
Public.

Description

update armv6 floating point defaults Update the armv6 floating point defaults as suggested in http://crbug.com/234135 BUG=234135 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240891

Patch Set 1 #

Patch Set 2 : set arm_fpu=vfp instead for armv6 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mostyn Bramley-Moore
@digit1: do you know if there's a try bot that I can use to test ...
7 years ago (2013-12-04 19:04:06 UTC) #1
Mostyn Bramley-Moore
The arm-linux-androideabi-4.7 toolchain in third_party/android_tools only lists the following fpu args: fpa fpe2 fpe3 fpv4-sp-d16 ...
7 years ago (2013-12-04 20:08:13 UTC) #2
Mostyn Bramley-Moore
@digit1: *ping*
7 years ago (2013-12-15 09:21:51 UTC) #3
digit1
Oops sorry, lgtm, I really thought I had already approved this. Apart from that, yes ...
7 years ago (2013-12-16 08:04:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/104403004/20001
7 years ago (2013-12-16 08:05:13 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=202899
7 years ago (2013-12-16 09:08:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/104403004/20001
7 years ago (2013-12-16 09:16:36 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-16 14:11:39 UTC) #8
Message was sent while issue was closed.
Change committed as 240891

Powered by Google App Engine
This is Rietveld 408576698