Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1043973003: Revert of Add record-as-much-as-possible mode for about://tracing. (Closed)

Created:
5 years, 8 months ago by nednguyen
Modified:
5 years, 8 months ago
Reviewers:
nduca, Nat
CC:
chromium-reviews, darin-cc_chromium.org, jam, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add record-as-much-as-possible mode for about://tracing. (patchset #1 id:1 of https://codereview.chromium.org/1033223008/) Reason for revert: Speculative revert to see if this cause 340kb increase in size (BUG=471610 ) Original issue's description: > Add record-as-much-as-possible mode for about://tracing. > > Update DEPS for trace-viewer to include the 3 tracing modes selector. > > BUG=396081 > TEST= > > Committed: https://crrev.com/8e752353b04c52cb3ba1d54b79fce241c0be53d3 > Cr-Commit-Position: refs/heads/master@{#322689} TBR=nduca@chromium.org,nduca@google.com BUG=396081 Committed: https://crrev.com/bd28da0bfa3c2105937e61c6fe806c7ba7d43f01 Cr-Commit-Position: refs/heads/master@{#322853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/tracing_ui.cc View 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nednguyen
Created Revert of Add record-as-much-as-possible mode for about://tracing.
5 years, 8 months ago (2015-03-30 18:59:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043973003/1
5 years, 8 months ago (2015-03-30 19:00:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-30 20:28:23 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bd28da0bfa3c2105937e61c6fe806c7ba7d43f01 Cr-Commit-Position: refs/heads/master@{#322853}
5 years, 8 months ago (2015-03-30 20:30:54 UTC) #5
nednguyen
5 years, 8 months ago (2015-03-30 23:49:37 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1045123003/ by nednguyen@google.com.

The reason for reverting is: Size increase in
https://code.google.com/p/chromium/issues/detail?id=471610 is WAI..

Powered by Google App Engine
This is Rietveld 408576698