Introduce AlternativeServiceInfo.

Introduce AlternativeServiceInfo.

* Introduce AlternativeServiceInfo and use it instead of AlternateProtocolInfo
  in HttpServerPropertiesImpl.
* Change language in method and variable names and comments to consistently talk
  about alternative service instead of alternate protocol (except for threshold
  related occurrences).
* Update HttpServerPropertiesManager to save by key "alternative_service"
  instead of "alternate_protocol", while still being able to read old
  preferences.
* Add TODO(bnc) at a couple of places.

BUG=392575
Committed: https://crrev.com/4988e439c1a14779f32b4dc9c289d9e4bad467af
Cr-Commit-Position: refs/heads/master@{#322968}

[Bence, 2015-03-30 21:31:08]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2015-03-30 21:31:10]

Ryan: PTAL.  Thanks.

https://codereview.chromium.org/1043973002/diff/20001/net/http/http_network_t...
File net/http/http_network_transaction_unittest.cc (left):

https://codereview.chromium.org/1043973002/diff/20001/net/http/http_network_t...
net/http/http_network_transaction_unittest.cc:7844:
AlternateProtocolFromNextProto(next_proto), "alternative.host", 443);
This was an error I introduced in 
https://crrev.com/1018943002.

[Ryan Hamilton, 2015-03-30 23:07:49]

lgtm

Great!

https://codereview.chromium.org/1043973002/diff/60001/net/http/http_server_pr...
File net/http/http_server_properties_impl.cc (right):

https://codereview.chromium.org/1043973002/diff/60001/net/http/http_server_pr...
net/http/http_server_properties_impl.cc:393: const {
This formatting looks strange. I would have expected the return value on the
previous line. Did you git cl format net this change?

https://codereview.chromium.org/1043973002/diff/60001/net/http/http_server_pr...
File net/http/http_server_properties_manager.cc (right):

https://codereview.chromium.org/1043973002/diff/60001/net/http/http_server_pr...
net/http/http_server_properties_manager.cc:553: return true;
nit: can you change the polarity of the if, and move the return into the if()
body, and then remove the else clause?

[Bence, 2015-03-31 01:06:16]

Thanks.

https://codereview.chromium.org/1043973002/diff/60001/net/http/http_server_pr...
File net/http/http_server_properties_impl.cc (right):

https://codereview.chromium.org/1043973002/diff/60001/net/http/http_server_pr...
net/http/http_server_properties_impl.cc:393: const {
On 2015/03/30 23:07:49, Ryan Hamilton wrote:
> This formatting looks strange. I would have expected the return value on the
> previous line. Did you git cl format net this change? 

Hey, it looks strange to me too.  But git cl format keeps going back to this if
I just put everything on one (too long) line, or if I break lines after the
return type.  Weird.

https://codereview.chromium.org/1043973002/diff/60001/net/http/http_server_pr...
File net/http/http_server_properties_manager.cc (right):

https://codereview.chromium.org/1043973002/diff/60001/net/http/http_server_pr...
net/http/http_server_properties_manager.cc:553: return true;
On 2015/03/30 23:07:49, Ryan Hamilton wrote:
> nit: can you change the polarity of the if, and move the return into the if()
> body, and then remove the else clause?

Done.

[Bence, 2015-03-31 02:19:30]

The CQ bit was checked by bnc@chromium.org

[Bence, 2015-03-31 02:19:31]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1043973002/#ps80001
(title: "Early return.")

[commit-bot: I haz the power, 2015-03-31 02:19:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1043973002/80001

[commit-bot: I haz the power, 2015-03-31 03:06:36]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-31 03:07:22]

Patchset 5 (id:??) landed as
https://crrev.com/4988e439c1a14779f32b4dc9c289d9e4bad467af
Cr-Commit-Position: refs/heads/master@{#322968}