Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1292)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/os_linux.cc

Issue 1043943002: A few fixes for ARMv5TE. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/regexp_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/os_linux.cc
===================================================================
--- runtime/vm/os_linux.cc (revision 44777)
+++ runtime/vm/os_linux.cc (working copy)
@@ -504,11 +504,16 @@
}
+// TODO(regis, iposva): When this function is no longer called from the
+// CodeImmutability test in object_test.cc, it will be called only from the
+// simulator, which means that only the Intel implementation is needed.
void OS::DebugBreak() {
#if defined(HOST_ARCH_X64) || defined(HOST_ARCH_IA32)
asm("int $3");
-#elif defined(HOST_ARCH_ARM)
+#elif defined(HOST_ARCH_ARM) && !defined(__THUMBEL__)
asm("svc #0x9f0001"); // __ARM_NR_breakpoint
+#elif defined(HOST_ARCH_ARM) && defined(__THUMBEL__)
+ UNIMPLEMENTED();
#elif defined(HOST_ARCH_MIPS) || defined(HOST_ARCH_ARM64)
UNIMPLEMENTED();
#else
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/regexp_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698