Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1043933002: Support languages other than the default on linux (Closed)

Created:
5 years, 8 months ago by deejay
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support languages other than the default on linux Regarding the latest code on linux, It was always setting by default language even if value of language was existed. So we need to add routine for setting language via "spd_set_language". BUG=289548 Committed: https://crrev.com/ff4018b80395433657222d6eb0483b2349b1e007 Cr-Commit-Position: refs/heads/master@{#326764}

Patch Set 1 #

Patch Set 2 : Rebase with latest code and remove white space #

Patch Set 3 : Fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/linux/system.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/speech/tts_linux.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/speech-dispatcher/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
deejay
On 2015/04/23 07:01:43, deejay wrote: > mailto:djmix.kim@samsung.com changed reviewers: > + mailto:cjhopman@chromium.org, mailto:dmazzoni@chromium.org, mailto:dpranke@chromium.org, > ...
5 years, 8 months ago (2015-04-23 07:08:28 UTC) #2
Dirk Pranke
I defer to dmazzoni on this. lgtm if he approves.
5 years, 8 months ago (2015-04-23 22:30:52 UTC) #3
dmazzoni
lgtm
5 years, 8 months ago (2015-04-23 22:33:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043933002/20001
5 years, 8 months ago (2015-04-23 22:34:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/64997)
5 years, 8 months ago (2015-04-23 22:52:48 UTC) #8
deejay
On 2015/04/23 22:52:48, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 8 months ago (2015-04-24 08:22:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043933002/40001
5 years, 8 months ago (2015-04-24 08:23:34 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-24 09:23:44 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 09:24:30 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ff4018b80395433657222d6eb0483b2349b1e007
Cr-Commit-Position: refs/heads/master@{#326764}

Powered by Google App Engine
This is Rietveld 408576698