rAF: Introduce FrameRequestCallbackCollection for managing rAF callbacks.

Source/core/inspector/InspectorTraceEvents.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/inspector/InspectorTraceEvents.h"
 
 #include "bindings/core/v8/ScriptCallStackFactory.h"
 #include "bindings/core/v8/ScriptGCEvent.h"
 #include "bindings/core/v8/ScriptSourceCode.h"
@@ skipping 408 matching lines @@
 PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorTimerRemoveEvent::data(ExecutionContext* context, int timerId)
 {
     return genericTimerData(context, timerId);
 }
 
 PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorTimerFireEvent::data(ExecutionContext* context, int timerId)
 {
     return genericTimerData(context, timerId);
 }
 
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorAnimationFrameEvent::data(Document* document, int callbackId)
+PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorAnimationFrameEvent::data(ExecutionContext* context, int callbackId)

[dgozman, 2015/03/31 10:10:05]

Maybe this whole event makes sense only for document? +caseq@ to answer this.

[caseq, 2015/03/31 10:27:42]

From what I understand, we can no longer assume the execution context is a
Document becuase the code is being generalized to handle compositor workers. If
so, the trace events should be fine(*), but I'm worried for
InspectorInstrumentation calls -- these may only be invoked by the main thread.

(*) we may still want some way of identifying the context, so we can tell apart
workers for different pages if they share the process, but I think this can be
deferred to a later stage, considering it would require some front-end support.

[sadrul, 2015/03/31 12:39:41]

Considering for the Document, we simply list the pointer to the frame, would it
make sense to do something similar for the worker like this:

  if (context->isDocument()) {
    value->SetString("frame", toHexString(toDocument(context)->frame()));
  } else if (context->isGlobalWorkerScope()) {
    value->SetString("worker", toHexString(toWorkerGlobalScope(context)));
  }

?

[sadrul, 2015/03/31 16:40:27]

Done.

 {
     RefPtr<TracedValue> value = TracedValue::create();
     value->setInteger("id", callbackId);
-    value->setString("frame", toHexString(document->frame()));
+    if (context->isDocument()) {
+        Document* document = toDocument(context);
+        value->setString("frame", toHexString(document->frame()));
+    }
     setCallStack(value.get());
     return value.release();
 }
 
 PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorWebSocketCreateEvent::data(Document* document, unsigned long identifier, const KURL& url, const String& protocol)
 {
     RefPtr<TracedValue> value = TracedValue::create();
     value->setInteger("identifier", identifier);
     value->setString("url", url.string());
     value->setString("frame", toHexString(document->frame()));
@@ skipping 268 matching lines @@
 }
 
 PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorAnimationStateEvent::data(const AnimationPlayer& player)
 {
     RefPtr<TracedValue> value = TracedValue::create();
     value->setString("state", player.playState());
     return value.release();
 }
 
 }